Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkchecker: Remove unneeded FIXME about intra-doc links #114539

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Aug 6, 2023

It was added by #77971 but the adder proposed that the added code is a good fallback to have in case rustdoc gets buggy, and I agree. So remove the FIXME.

This PR is part of #44366 which is E-help-wanted.

r? @jyn514 since you added the FIXME

@rustbot label T-dev-tools

It was added by 77971 but the adder proposed in that PR that the added
code is a good fallback to have in case rustdoc gets buggy, and I agree.
So remove the FIXME.
@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2023

Could not assign reviewer from: jyn514.
User(s) jyn514 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Aug 6, 2023
@ehuss
Copy link
Contributor

ehuss commented Aug 6, 2023

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 6, 2023

📌 Commit cf08888 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2023
@Enselic
Copy link
Member Author

Enselic commented Aug 6, 2023

Sorry, I accidentally forced push to this branch 😞

I forced push back to approved commit cf08888, but looks like someone needs to r+ again. Really sorry for the trouble :(

@ehuss
Copy link
Contributor

ehuss commented Aug 6, 2023

No worries!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 6, 2023

📌 Commit cf08888 has been approved by ehuss

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#114466 (Add Allocation to SMIR)
 - rust-lang#114505 (Add documentation to has_deref)
 - rust-lang#114519 (use offset_of! to calculate dirent64 field offsets)
 - rust-lang#114537 (Migrate GUI colors test to original CSS color format)
 - rust-lang#114539 (linkchecker: Remove unneeded FIXME about intra-doc links)

Failed merges:

 - rust-lang#114485 (Add trait decls to SMIR)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f542163 into rust-lang:master Aug 6, 2023
22 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 6, 2023
@Enselic Enselic deleted the unneeded-fixme branch August 17, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants