Issue numbers are enforced on active features; remove FIXME #114556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? @compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
cjgillot
reviewed
Aug 6, 2023
| @@ -108,8 +108,6 @@ impl UnstableFeatures { | |||
|
|
|||
| fn find_lang_feature_issue(feature: Symbol) -> Option<NonZeroU32> { | |||
| if let Some(info) = ACTIVE_FEATURES.iter().find(|t| t.name == feature) { | |||
| // FIXME (#28244): enforce that active features have issue numbers | |||
| // assert!(info.issue.is_some()) | |||
There was a problem hiding this comment.
Should we keep the assert uncommented?
There was a problem hiding this comment.
I tried but that ICEd because it hit so called "internal" features that does not have tracking issues (and those features are special cased by the tidy check )
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 6, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#114535 (bump schannel, miow to drop windows-sys 0.42) - rust-lang#114542 (interpret: use ConstPropNonsense for more const-prop induced issues) - rust-lang#114543 (add tests for some fixed ConstProp ICEs) - rust-lang#114550 (Generate better function argument names in global_allocator expansion) - rust-lang#114556 (Issue numbers are enforced on active features; remove FIXME) - rust-lang#114558 (Remove FIXME about NLL diagnostic that is already improved) Failed merges: - rust-lang#114485 (Add trait decls to SMIR) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #51090 tidy enforces that active features have an issue number, so remove the FIXME.
This PR is part of #44366 which is E-help-wanted.