-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add way to differentiate argument locals from other locals in Stable MIR #117095
Commits on Oct 25, 2023
-
Add arg_count field to Body in Stable MIR
This field allows SMIR consumers to identify which locals correspond to argument locals. It simply exposes the arg_count field from the MIR representation.
Configuration menu - View commit details
-
Copy full SHA for e4c41b0 - Browse repository at this point
Copy the full SHA e4c41b0View commit details -
Replace arg_count in public API with return/arg getters
This commit hides the arg_count field in Body and instead exposes more stable and user-friendly methods to get the return and argument locals. As a result, Body instances must now be constructed using the `new` function.
Configuration menu - View commit details
-
Copy full SHA for 93d1b3e - Browse repository at this point
Copy the full SHA 93d1b3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4d80a5 - Browse repository at this point
Copy the full SHA f4d80a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 372c533 - Browse repository at this point
Copy the full SHA 372c533View commit details -
Add a public API to get all body locals
This is particularly helpful for the ui tests, but also could be helpful for Stable MIR users who just want all the locals without needing to concatenate responses
Configuration menu - View commit details
-
Copy full SHA for 39b293f - Browse repository at this point
Copy the full SHA 39b293fView commit details -
Rename internal_locals to inner_locals
The word internal has connotations about information that's not exposed. It's more accurate to say that the remaining locals apply only to the inner part of the function, so I'm renaming them to inner locals.
Configuration menu - View commit details
-
Copy full SHA for fe4dfb8 - Browse repository at this point
Copy the full SHA fe4dfb8View commit details -
Update Place and Operand to take slices
The latest locals() method in stable MIR returns slices instead of vecs. This commit also includes fixes to the existing tests that previously referenced the private locals field.
Configuration menu - View commit details
-
Copy full SHA for 4b23bd4 - Browse repository at this point
Copy the full SHA 4b23bd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bac7d5b - Browse repository at this point
Copy the full SHA bac7d5bView commit details
Commits on Oct 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d55487d - Browse repository at this point
Copy the full SHA d55487dView commit details