coverage: Avoid a possible query stability hazard in CoverageCounters
#119401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iteration order of this hashmap can potentially affect the relative creation order of MIR blocks.
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119375 (Merge Coroutine lowering functions) - rust-lang#119393 (Use filter instead of filter_map in Parser::expected_one_of_not_found) - rust-lang#119401 (coverage: Avoid a possible query stability hazard in `CoverageCounters`) - rust-lang#119402 (Also walk bindings created by if-let guards) - rust-lang#119404 (Enable profiler in dist-powerpc-linux) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2023
Rollup merge of rust-lang#119401 - Zalathar:query-stability, r=Nilstrieb coverage: Avoid a possible query stability hazard in `CoverageCounters` rust-lang#119252 revealed a possible query stability hazard in `CoverageCounters`: we iterate over the entries of an `FxHashMap` in a way that allows the iteration order to potentially affect the relative creation order of MIR blocks. I'm not sure whether there's an actual stability problem or not in practice, but it's certainly a hazard, and I don't see any reason not to switch over to `FxIndexMap` to avoid potential issues. --- This can either be merged on its own, or incorporated into rust-lang#119252. cc `@Enselic` r? `@cjgillot`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#119252 revealed a possible query stability hazard in
CoverageCounters: we iterate over the entries of anFxHashMapin a way that allows the iteration order to potentially affect the relative creation order of MIR blocks.I'm not sure whether there's an actual stability problem or not in practice, but it's certainly a hazard, and I don't see any reason not to switch over to
FxIndexMapto avoid potential issues.This can either be merged on its own, or incorporated into #119252.
cc @Enselic
r? @cjgillot