Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the current target instead of iterating over all targets #119548

Merged
merged 1 commit into from
Jan 7, 2024

Commits on Jan 3, 2024

  1. Use the current target instead of iterating over all targets.

    Since we already iterate through targets in StepDescription::maybe_run, there is no need to
    iterate targets again in the install step for std.
    
    Compared the results before and after applying the changes to install step of std, and there were no differences.
    
    ```sh
    
      ~/devspace/.other/rustc-builds  $ sha256sum ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-*
    c2ea86fc25ffac87b0b135f31ba9644ad97549da4c050c3921b437d1e18285fd  ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-pc-windows-gnu
    d2f1081a779962e2cbc27f53191783d13428abd0964465547af78ce34c7251dd  ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-unknown-linux-gnu
    
      ~/devspace/.other/rustc-builds  $ sha256sum ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-*
    c2ea86fc25ffac87b0b135f31ba9644ad97549da4c050c3921b437d1e18285fd  ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-pc-windows-gnu
    d2f1081a779962e2cbc27f53191783d13428abd0964465547af78ce34c7251dd  ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-unknown-linux-gnu
    
    ```
    
    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    15bb29e View commit details
    Browse the repository at this point in the history