-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #119603
Rollup of 8 pull requests #119603
Commits on Dec 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5c0e62c - Browse repository at this point
Copy the full SHA 5c0e62cView commit details
Commits on Dec 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 90d6fe2 - Browse repository at this point
Copy the full SHA 90d6fe2View commit details
Commits on Dec 29, 2023
-
Allow emitting diagnostics from the
#[diagnostic]
namespace without anightly feature (Using this attribute still requires a nightly feature, this just enables that this feature does not need to be enabled on the child crate as well)
Configuration menu - View commit details
-
Copy full SHA for 3ab43e5 - Browse repository at this point
Copy the full SHA 3ab43e5View commit details -
Replace some usage of
#[rustc_on_unimplemented]
with`#[diagnostic::on_unimplemented]` This commit replaces those `#[rustc_on_unimplemented]` attributes with their equivalent `#[diagnostic::on_unimplemented]` where this is supported (So no filter or any extended option)
Configuration menu - View commit details
-
Copy full SHA for cd9425b - Browse repository at this point
Copy the full SHA cd9425bView commit details -
Add a test that emitting diagnostics does not require the crate to use
the corresponding feature.
Configuration menu - View commit details
-
Copy full SHA for eabf4df - Browse repository at this point
Copy the full SHA eabf4dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc31adc - Browse repository at this point
Copy the full SHA cc31adcView commit details
Commits on Jan 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fdd991f - Browse repository at this point
Copy the full SHA fdd991fView commit details
Commits on Jan 3, 2024
-
Rename some
Diagnostic
setters.`Diagnostic` has 40 methods that return `&mut Self` and could be considered setters. Four of them have a `set_` prefix. This doesn't seem necessary for a type that implements the builder pattern. This commit removes the `set_` prefixes on those four methods.
Configuration menu - View commit details
-
Copy full SHA for 505c137 - Browse repository at this point
Copy the full SHA 505c137View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fe5d5d - Browse repository at this point
Copy the full SHA 5fe5d5dView commit details -
Remove forward for
downgrade_to_delayed_bug
.It's not used, and doesn't quite fit the general pattern. Also, `Diagnostic::downgrade_to_delayed_bug` doesn't need to return `&mut Self` for the same reason.
Configuration menu - View commit details
-
Copy full SHA for 096b844 - Browse repository at this point
Copy the full SHA 096b844View commit details -
- Move comments onto corresponding `Diagnostic` methods. - Make formatting more consistent.
Configuration menu - View commit details
-
Copy full SHA for caefa55 - Browse repository at this point
Copy the full SHA caefa55View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4a6239 - Browse repository at this point
Copy the full SHA b4a6239View commit details -
Remove unused
DiagnosticBuilder::struct_almost_fatal
.`create_almost_fatal` and `emit_almost_fatal` are always used instead.
Configuration menu - View commit details
-
Copy full SHA for 1e92223 - Browse repository at this point
Copy the full SHA 1e92223View commit details
Commits on Jan 4, 2024
-
Avoid some
rustc_errors::
qualifiers.These are misleading, because the mixture of `Level` and `rustc_errors::Level` makes it look like there are two different types involved.
Configuration menu - View commit details
-
Copy full SHA for 9560c58 - Browse repository at this point
Copy the full SHA 9560c58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d35981 - Browse repository at this point
Copy the full SHA 4d35981View commit details -
Inline and remove
StringReader::struct_fatal_span_char
.It has a single call site.
Configuration menu - View commit details
-
Copy full SHA for 8e6bca6 - Browse repository at this point
Copy the full SHA 8e6bca6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d48f69 - Browse repository at this point
Copy the full SHA 1d48f69View commit details -
Remove
is_lint
field fromLevel::Error
.Because it's redundant w.r.t. `Diagnostic::is_lint`, which is present for every diagnostic level. `struct_lint_level_impl` was the only place that set the `Error` field to `true`, and it's also the only place that calls `Diagnostic::is_lint()` to set the `is_lint` field.
Configuration menu - View commit details
-
Copy full SHA for 8388112 - Browse repository at this point
Copy the full SHA 8388112View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bc3552 - Browse repository at this point
Copy the full SHA 4bc3552View commit details -
rustc_mir_transform: Make DestinationPropagation stable for queries
By using FxIndexMap instead of FxHashMap, so that the order of visiting of locals is deterministic. We also need to bless copy_propagation_arg.foo.DestinationPropagation.panic*.diff. Do not review the diff of the diff. Instead look at the diff file before and after this commit. Both before and after this commit, 3 statements are replaced with nop. It's just that due to change in ordering, different statements are replaced. But the net result is the same.
Configuration menu - View commit details
-
Copy full SHA for f603bab - Browse repository at this point
Copy the full SHA f603babView commit details
Commits on Jan 5, 2024
-
Rollup merge of rust-lang#118680 - djkoloski:shell_argfiles, r=compil…
…er-errors Add support for shell argfiles Closes rust-lang/compiler-team#684
Configuration menu - View commit details
-
Copy full SHA for 9065e4b - Browse repository at this point
Copy the full SHA 9065e4bView commit details -
Rollup merge of rust-lang#119151 - Jules-Bertholet:no-foreign-doc-hid…
…den-suggest, r=davidtwco Hide foreign `#[doc(hidden)]` paths in import suggestions Stops the compiler from suggesting to import foreign `#[doc(hidden)]` paths. ``@rustbot`` label A-suggestion-diagnostics
Configuration menu - View commit details
-
Copy full SHA for 33d1c50 - Browse repository at this point
Copy the full SHA 33d1c50View commit details -
Rollup merge of rust-lang#119216 - weiznich:use_diagnostic_namespace_…
…in_stdlib, r=compiler-errors Use diagnostic namespace in stdlib This required a minor fix to have the diagnostics shown in third party crates when the `diagnostic_namespace` feature is not enabled. See rust-lang@5d63f5d for details. I've opted for having a single PR for both changes as it's really not that much code. If it is required it should be easy to split up the change into several PR's. r? `@compiler-errors`
Configuration menu - View commit details
-
Copy full SHA for b4f4983 - Browse repository at this point
Copy the full SHA b4f4983View commit details -
Rollup merge of rust-lang#119350 - fmease:lazy-ty-aliases-implied-bou…
…nds, r=compiler-errors Imply outlives-bounds on lazy type aliases Fixes rust-lang#118479. r? types
Configuration menu - View commit details
-
Copy full SHA for 2cf6067 - Browse repository at this point
Copy the full SHA 2cf6067View commit details -
Rollup merge of rust-lang#119538 - nnethercote:cleanup-errors-5, r=co…
…mpiler-errors Cleanup error handlers: round 5 More rustc_errors cleanups. A sequel to rust-lang#119171. r? `@compiler-errors`
Configuration menu - View commit details
-
Copy full SHA for cf4cd93 - Browse repository at this point
Copy the full SHA cf4cd93View commit details -
Rollup merge of rust-lang#119563 - compiler-errors:coroutine-resume, …
…r=oli-obk Check yield terminator's resume type in borrowck In borrowck, we didn't check that the lifetimes of the `TerminatorKind::Yield`'s `resume_place` were actually compatible with the coroutine's signature. That means that the lifetimes were totally going unchecked. Whoops! This PR implements this checking. Fixes rust-lang#119564 r? types
Configuration menu - View commit details
-
Copy full SHA for 5cf7bbe - Browse repository at this point
Copy the full SHA 5cf7bbeView commit details -
Rollup merge of rust-lang#119589 - petrochenkov:cdatalock, r=Mark-Sim…
…ulacrum cstore: Remove unnecessary locking from `CrateMetadata` Locks and atomics in `CrateMetadata` fields were necessary before rust-lang#107765 when `CStore` was cloneable, but now they are not necessary and can be removed after restructuring the code a bit to please borrow checker. All remaining locked fields in `CrateMetadata` are lazily populated caches.
Configuration menu - View commit details
-
Copy full SHA for 2e1bdea - Browse repository at this point
Copy the full SHA 2e1bdeaView commit details -
Rollup merge of rust-lang#119591 - Enselic:DestinationPropagation-sta…
…ble, r=cjgillot rustc_mir_transform: Make DestinationPropagation stable for queries By using `FxIndexMap` instead of `FxHashMap`, so that the order of visiting of locals is deterministic. We also need to bless `copy_propagation_arg.foo.DestinationPropagation.panic*.diff`. Do not review the diff of the diff. Instead look at the diff files before and after this commit. Both before and after this commit, 3 statements are replaced with nop. It's just that due to change in ordering, different statements are replaced. But the net result is the same. In other words, compare this diff (before fix): * https://github.com/rust-lang/rust/blob/090d5eac722000906cc00d991f2bf052b0e388c3/tests/mir-opt/dest-prop/copy_propagation_arg.foo.DestinationPropagation.panic-unwind.diff With this diff (after fix): * https://github.com/rust-lang/rust/blob/f603babd63a607e155609dc0277806e559626ea0/tests/mir-opt/dest-prop/copy_propagation_arg.foo.DestinationPropagation.panic-unwind.diff and you can see that both before and after the fix, we replace 3 statements with `nop`s. I find it _slightly_ surprising that the test this PR affects did not previously fail spuriously due to the indeterminism of `FxHashMap`, but I guess in can be explained with the predictability of small `FxHashMap`s with `usize` (`Local`) keys, or something along those lines. This should fix [this](rust-lang#119252 (comment)) comment, but I wanted to make a separate PR for this fix for a simpler development and review process. Part of rust-lang#84447 which is E-help-wanted. r? `@cjgillot` who is reviewer for the highly related PR rust-lang#119252.
Configuration menu - View commit details
-
Copy full SHA for e147a1b - Browse repository at this point
Copy the full SHA e147a1bView commit details