Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UEFI target docs #119937

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Improve UEFI target docs #119937

merged 2 commits into from
Jan 14, 2024

Conversation

nicholasbishop
Copy link
Contributor

  • Add a section showing exactly how to build a driver instead of an application
  • Add links to the crates mentioned in the doc

CC @dvdhrm

@rustbot
Copy link
Collaborator

rustbot commented Jan 13, 2024

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2024
@ehuss
Copy link
Contributor

ehuss commented Jan 13, 2024

@bors delegate=dvdhrm

@bors
Copy link
Contributor

bors commented Jan 13, 2024

✌️ @dvdhrm, you can now approve this pull request!

If @ehuss told you to "r=me" after making some further change, please make that change, then do @bors r=@ehuss

dvdhrm
dvdhrm approved these changes Jan 13, 2024
View reviewed changes
Copy link
Contributor

@dvdhrm dvdhrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@dvdhrm
Copy link
Contributor

dvdhrm commented Jan 13, 2024

@bors r=@ehuss

@bors
Copy link
Contributor

bors commented Jan 13, 2024

📌 Commit 3402f07 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2024
@ehuss
Copy link
Contributor

ehuss commented Jan 13, 2024

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Jan 13, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 13, 2024
@bors
Auto merge of rust-lang#119945 - matthiaskrgr:rollup-oy3e1j2, r=matth…
3deb9bb 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119189 (Move section "Installing from Source" to seperate file)
 - rust-lang#119925 (store the segment name when resolution fails)
 - rust-lang#119935 (Move personality implementation out of PAL)
 - rust-lang#119937 (Improve UEFI target docs)
 - rust-lang#119938 (Allow unauthorized users to user the has-merge-commits label)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f7a76a9 into rust-lang:master Jan 14, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
@rust-timer
Unrolled build for rust-lang#119937
023fb88 
Rollup merge of rust-lang#119937 - nicholasbishop:bishop-uefi-doc-improve, r=ehuss

Improve UEFI target docs

* Add a section showing exactly how to build a driver instead of an application
* Add links to the crates mentioned in the doc

CC `@dvdhrm`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdhrm dvdhrm dvdhrm approved these changes

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nicholasbishop @rustbot @ehuss @bors @dvdhrm