add several resolution test cases

[bvanjoi]

r? @petrochenkov

[petrochenkov]

The tests/ui/imports/ambiguous-4.rs change can also be moved to this PR.
@rustbot author

[bvanjoi]

Do you think we should create an issue addressing the edge case mentioned in #114682 (comment)?

[petrochenkov]

Maybe, I just don't understand what is the issue with #114682 (comment).
The import should refer to both extern_crate::d::max and extern_crate::e::max in different namespaces, but that comment only considers one namespace.

[bvanjoi]

// extern-crate.rs
mod d {
    pub fn max() {}
    pub(crate) mod max {}
}

mod e {
    pub type max = i32;
}

pub use self::d::*;
pub use self::e::*;

// code.rs
use extern_crate::max; // refer to the fn `extern_crate::d::max`

fn main() {}

Given the current logic, (Mod(roo_in_extern_crate), Ns(Type), Ident(max)) is identified as an ambiguous item and hence, omitted in the local crate. However, in my opinion, (Mod(root_in_local_crate), Ns(Type), Ident(max)) should point to extern_crate::e::max. This is because extern_crate::d::max has been restricted within extern_crate. Yet, this is not currently being reflected.

[petrochenkov]

In any case, adding a test for this would be useful.

[bvanjoi]

Additional details have been appended to issue-114682-2.rs.

[petrochenkov]

@bors r+

[bors]

📌 Commit 851d4c4 has been approved by petrochenkov

It is now in the queue for this repository.