pattern_analysis: Gracefully abort on type incompatibility

[Nadrieril]

This leaves the option for a consumer of the crate to return Err instead of panicking on type error. rust-analyzer could use that (e.g. rust-lang/rust-analyzer#15808).

Since the only use of TypeCx::bug is in Constructor::is_covered_by, it is tempting to return false instead of Err(), but that would cause "non-exhaustive match" false positives.

r? @compiler-errors

[Nadrieril]

This will regress match-stress

@bors try @rust-timer queue

[bors]

⌛ Trying commit 8ea37ae with merge 8d0058e...

[bors]

☀️ Try build successful - checks-actions
Build commit: 8d0058e (8d0058ec16c5c41713eb54d3da9fd1ead2edc5e9)

[rust-timer]

Finished benchmarking commit (8d0058e): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	3.0%	[1.3%, 4.7%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 663.194s -> 663.003s (-0.03%)
Artifact size: 308.36 MiB -> 308.37 MiB (0.01%)

[Nadrieril]

Lol, for once I did not regress match-stress

[Nadrieril]

Grmbl, bors didn't tell me about the merge conflict again :(

[Nadrieril]

I rebased onto #120321 because conflicts, only the last commit is this PR

[compiler-errors]

r=me

[compiler-errors]

@bors r+

[bors]

📌 Commit 400dc46 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

[Nadrieril]

Ah nice, CI is back on

@bors rollup

[Nadrieril]

What am I doing, this one had a perf regression

@bors rollup=never

[bors]

⌛ Testing commit 400dc46 with merge f067fd6...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f067fd6 to master...

[rust-timer]

Finished benchmarking commit (f067fd6): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.8%, 2.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.4%]	2
Regressions ❌ (secondary)	3.9%	[3.5%, 4.5%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-3.5%, -3.5%]	1
All ❌✅ (primary)	3.3%	[3.3%, 3.4%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 660.166s -> 661.246s (0.16%)
Artifact size: 308.14 MiB -> 308.13 MiB (-0.00%)

[Kobzol]

The pattern matching machinery is now being changed a lot, and the match-stress benchmark is swinging back and forth. I don't think it's needed to dig deeper on this.

@rustbot label: +perf-regression-triaged