Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backports #120352

Merged
merged 3 commits into from
Jan 27, 2024
Merged

[beta] backports #120352

merged 3 commits into from
Jan 27, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jan 25, 2024

r? ghost

@the8472 @cuviper
update internal ASCII art comment for vec specializations
dde3897 
(cherry picked from commit b28a953)
@the8472 @cuviper
remove alignment-changing in-place collect
e55be1a 
Currently stable users can't benefit from this because GlobaAlloc doesn't support
alignment-changing realloc and neither do most posix allocators.
So in practice it always results in an extra memcpy.

(cherry picked from commit 85d1787)
@the8472 @cuviper
fix: Drop guard was deallocating with the incorrect size
73b36b1 
InPlaceDstBufDrop holds onto the allocation before the shrinking happens
which means it must deallocate the destination elements but the source
allocation.

(cherry picked from commit 5796b3c)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 25, 2024
@cuviper
Copy link
Member Author

cuviper commented Jan 25, 2024

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 25, 2024

📌 Commit 73b36b1 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2024
@Nadrieril Nadrieril mentioned this pull request Jan 27, 2024
Closed
@bors
Copy link
Contributor

bors commented Jan 27, 2024

⌛ Testing commit 73b36b1 with merge 1633e2a...

@bors
Copy link
Contributor

bors commented Jan 27, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 1633e2a to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 27, 2024
@bors bors merged commit 1633e2a into rust-lang:beta Jan 27, 2024
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Jan 27, 2024
@cuviper cuviper deleted the beta-next branch February 14, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cuviper @bors @rustbot @the8472