Make most bootstrap step types !Copy #121570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @clubby789 rustbot has assigned @clubby789. Use r? to explicitly pick a reviewer |
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
rustbot
added
S-waiting-on-review
clubby789
reviewed
Feb 24, 2024
This makes all bootstrap types except for `Compiler` and `TargetSelection` `!Copy`. This makes it easier to modify them by adding !Copy types in the future and comes at no cost of code clarity, the impls were completely unused.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
(commenting here even though I've already said this elsewhere)
This is a nice cleanup and I'm happy to see this PR, but what I wanted was a non-Copy |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#119590 (Stabilize `cfg_target_abi`) - rust-lang#120805 (make non-PartialEq-typed consts as patterns a hard error) - rust-lang#121060 (Add newtypes for bool fields/params/return types) - rust-lang#121284 (Add test cases for inlining compiler-private items) - rust-lang#121324 (pattern_analysis: factor out unspecialization) - rust-lang#121409 (Prevent cycle in implied predicates computation) - rust-lang#121513 (Fix sgx unit test compilation) - rust-lang#121570 (Make most bootstrap step types !Copy) - rust-lang#121586 (Don't use `unwrap()` in `ArrayIntoIter` lint when typeck fails) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2024
Rollup merge of rust-lang#121570 - Nilstrieb:!copy, r=clubby789 Make most bootstrap step types !Copy This makes all bootstrap types except for `Compiler` and `TargetSelection` `!Copy`. This makes it easier to modify them by adding !Copy types in the future, something that `@saethlin` has complained about before, and comes at no cost of code clarity, the impls were completely unused. Making `Compiler` and `TargetSelection` `!Copy` (which would allow getting rid of interning) is highly nontrivial as they are used and copied **all over the place**. This should hopefully get most of the benefits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all bootstrap types except for
CompilerandTargetSelection!Copy. This makes it easier to modify them by adding !Copy types in the future, something that @saethlin has complained about before, and comes at no cost of code clarity, the impls were completely unused.Making
CompilerandTargetSelection!Copy(which would allow getting rid of interning) is highly nontrivial as they are used and copied all over the place. This should hopefully get most of the benefits.