…ttern

closes rust-lang#121502

Fixes rust-lang#120785

In the previous code, the success block of `lhs` would jump directly to the
success block of `rhs`. However, `rhs_success_block` could already contain
statements that are specific to the RHS, and the direct goto causes them to be
executed in the LHS success path as well.

This patch therefore creates a fresh block that the LHS and RHS success blocks
can both jump to.

We have `use Level::*;` in this file.

Removes unused `typeid_for_fnsig` for simplifying the compiler CFI API.

By just emitting them immediately, because it does happen in practice,
when errors are downgraded to delayed bugs.

We already had one case in `lint.rs` where we handled this at the
callsite. This commit changes things so it's handled within
`stash_diagnostic` instead, because rust-lang#121812 identified a second case,
and it's possible there are more.

Fixes rust-lang#121812.

…g, r=michaelwoerister

Fix incorrect suggestion for uninitialized binding in pattern

Fixes rust-lang#120634

…nethercote

Improve error messages for generics with default parameters

Fixes rust-lang#120785

Issue: Previously, all type parameters with default types were deliberately ignored to simplify error messages. For example, an error message for Box type would display `Box<T>` instead of `Box<T, _>`. But, this resulted in unclear error message when a concrete type was used instead of the default type.

Fix: This PR fixes it by checking if a concrete type is specified after a default type to display the entire type name or the simplified type name.

…472,compiler-errors

Add tidy check for .stderr/.stdout files for non-existent test revisions

Closes rust-lang#77498.

…aelwoerister

make unused_imports less assertive in test modules

closes rust-lang#121502

This is a fairly small change and I used the fix suggested in the example expected error message.
Not sure if I should've rather used the alternatives but this one seems the most descriptive.

Some alternatives:
- if this is meant to be a test module, add `#[cfg(test)]` to the containing module
- try adding #[cfg(test)] to this test module
- consider adding #[allow(unused_imports)] if you want to silent the lint on the unused import
- consider removing the unused import

…-mutex-unlock, r=jhpratt

Remove `Mutex::unlock` Function

As of the completion of the FCP in rust-lang#81872 (comment), it has come to the conclusion to be closed.

This PR removes the function entirely in light of the above.

Closes rust-lang#81872.

Make the success arms of `if lhs || rhs` meet up in a separate block

Extracted from rust-lang#118305, where this is necessary to avoid introducing a bug when injecting marker statements into the then/else arms.

---

In the previous code (rust-lang#111752), the success block of `lhs` would jump directly to the success block of `rhs`. However, `rhs_success_block` could already contain statements that are specific to the RHS, and the direct goto causes them to be executed in the LHS success path as well.

This patch therefore creates a fresh block that the LHS and RHS success blocks can both jump to.

---

I think the reason we currently get away with this is that `rhs_success_block` usually doesn't contain anything other than StorageDead statements for locals used by the RHS, and those statements don't seem to cause problems in the LHS success path (which never makes those locals live).

But if we start adding meaningful statements for branch coverage (or MC/DC coverage), it's important to keep the LHS and RHS blocks separate.

…eid-for-fnsig, r=workingjubilee

CFI: Remove unused `typeid_for_fnsig`

Removes unused `typeid_for_fnsig` for simplifying the compiler CFI API.

Handle stashing of delayed bugs

By just emitting them immediately, because it does happen in practice, when errors are downgraded to delayed bugs.

We already had one case in `lint.rs` where we handled this at the callsite. This commit changes things so it's handled within `stash_diagnostic` instead, because rust-lang#121812 identified a second case, and it's possible there are more.

Fixes rust-lang#121812.

r? ````@oli-obk````

Remove unused fluent messages

Unused fluent messages after rust-lang#121779

Fix typo in comment

"pop" should have been "prop"

…e-trait, r=Nilstrieb

Make `ZeroablePrimitive` trait unsafe.

Tracking issue: rust-lang#120257

r? `@dtolnay`

…piler-errors

normalizes-to: handle negative impls

necessary to build the stage 2 compiler in rust-lang#121848 😁

r? `@compiler-errors`