Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p=1 to weekly cargo update #121923

Closed
wants to merge 1 commit into from

Conversation

clubby789
Copy link
Contributor

Since bumping dependencies tends to be very conflictly.

Blocked on rust-lang/homu#211 (if that takes a while this could just be a followup comment instead).

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2024
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Mar 3, 2024

doesn't that mean we also have to p=1 everything that conflicts with an automatic cargo update because its in the queue for longer and equally conflicty?

@clubby789
Copy link
Contributor Author

Well my reasoning was that while a regular PR author can just rebase, the bot won't until the next CI run a week later

@matthiaskrgr
Copy link
Member

lol, so if there are merge conflicts or something else is broken, we just wait for another week? 😅

imo we should prioritize human-made prs since rebasing these requires a human to spend time, whereas remaking an automated cargo update ps is already automatized and doesn't really require any human intervention?

@Mark-Simulacrum
Copy link
Member

The workflow can already be run manually (at least by some people, not sure by who). Could we make it auto-rebase an open PR, say, every hour? It seems to me that the purpose here is similar to dependabot: we want to always have an open PR with the latest set of changes in it, that's approved at some time after it's opened (and shouldn't be changed while approved) but otherwise is continuously kept up to date.

@clubby789
Copy link
Contributor Author

Sounds reasonable. Maybe we can split this into 2 CI jobs, one to open a PR weekly and another to (hourly) rebase any currently-open PR?

@clubby789
Copy link
Contributor Author

I'd still like to add rollup=never if the Homu PR lands 🤞🏻

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Mar 16, 2024
…k-Simulacrum

Bump `cargo update` PR more often

r? `@Mark-Simulacrum`

(rust-lang#121923 (comment))
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2024
Rollup merge of rust-lang#122489 - clubby789:more-cargo-update, r=Mark-Simulacrum

Bump `cargo update` PR more often

r? `@Mark-Simulacrum`

(rust-lang#121923 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants