Subtree update of `rust-analyzer` #122628

lnicola · 2024-03-17T09:05:21Z

No description provided.

… other situations like module-relative uses, we can do more accurate redundant import checking. fixes rust-lang#117448 For example unnecessary imports in std::prelude that can be eliminated: ```rust use std::option::Option::Some;//~ WARNING the item `Some` is imported redundantly use std::option::Option::None; //~ WARNING the item `None` is imported redundantly ```

Tracking import use types for more accurate redundant import checking fixes rust-lang#117448 By tracking import use types to check whether it is scope uses or the other situations like module-relative uses, we can do more accurate redundant import checking. For example unnecessary imports in std::prelude that can be eliminated: ```rust use std::option::Option::Some;//~ WARNING the item `Some` is imported redundantly use std::option::Option::None; //~ WARNING the item `None` is imported redundantly ```

…m-ra

From `impl Into<DiagnosticMessage>` to `impl Into<Cow<'static, str>>`. Because these functions don't produce user-facing output and we don't want their strings to be translated.

…m-ra

minor: sync last two releases from downstream Turns out I made quite a mess on the last two syncs, and this PR is a mess too, but I hope it's fine.

internal: Remove synstructure const hack support The latest version of it no longer emits these

fix: Fix wrong where clause rendering on hover We were not accounting for proper newline indentation in some places making the hover look weird (or just straight up wrong for type aliases)

fix: incorrect handling of `use` and panic issue in `extract_module`. fix rust-lang#16826 This PR includes the following changes: 1. Simplify the implementation partially, removing many unnecessary loops and `clone()`. 2. When it is found that the top level of the selection contains a `use` statement, a copy of the `use` will be reinserted before extraction. (rust-lang#16826) 3. Fixed an issue during `extract_module`, where if the top level of the selected part contains `A` and `use A::B`, it caused a duplication of `use A`.

…m-ra

rustbot · 2024-03-17T09:05:28Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-03-17T09:05:30Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2024-03-17T09:09:17Z

r? ghost

rustbot · 2024-03-17T09:09:20Z

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

lnicola · 2024-03-17T09:26:04Z

@bors r+ p=1 subtree sync

bors · 2024-03-17T09:26:07Z

📌 Commit 20ecf07 has been approved by lnicola

It is now in the queue for this repository.

bors · 2024-03-17T10:48:12Z

⌛ Testing commit 20ecf07 with merge 8e918b7...

Subtree update of `rust-analyzer`

rust-log-analyzer · 2024-03-17T11:50:22Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test util::network::retry::with_retry_repeats_the_call_then_works ... ok

failures:

---- util::network::sleep::returns_in_order stdout ----
thread 'util::network::sleep::returns_in_order' panicked at src/cargo\util\network\sleep.rs:101:5:
  left: [1, 3, 2, 5, 6]
 right: [1, 2, 3, 5, 6]

bors · 2024-03-17T11:50:48Z

💔 Test failed - checks-actions

lnicola · 2024-03-17T11:52:00Z

Huh

@bors retry

bors · 2024-03-17T11:53:10Z

⌛ Testing commit 20ecf07 with merge a0c20d5...

bors · 2024-03-17T13:54:21Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing a0c20d5 to master...

rust-timer · 2024-03-17T15:20:24Z

Finished benchmarking commit (a0c20d5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.2%	[6.2%, 6.2%]	1
Improvements ✅ (primary)	-2.2%	[-2.4%, -2.0%]	9
Improvements ✅ (secondary)	-3.3%	[-4.6%, -1.8%]	21
All ❌✅ (primary)	-2.2%	[-2.4%, -2.0%]	9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[1.1%, 4.0%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.964s -> 668.793s (0.12%)
Artifact size: 312.79 MiB -> 312.78 MiB (-0.00%)

surechen and others added 30 commits February 18, 2024 16:38

Remove suspicious auto trait lint

e057365

Merge commit '4a8d0f7f565b6df45da5522dd7366a4df3460cd7' into sync-fro…

9e4ecc6

…m-ra

Add missing imports

2edd74b

Avoid using cfg(FALSE)

f206d8b

Merge commit '4ef6a49b44e8aa380da7522442234bfd7a52c55e' into sync-fro…

80470d5

…m-ra

Change message type in bug functions.

49c0b33

From `impl Into<DiagnosticMessage>` to `impl Into<Cow<'static, str>>`. Because these functions don't produce user-facing output and we don't want their strings to be translated.

Re-use InferenceTable by snapshotting in method resolution

593156a

Remove some unnecessary cloning in method_resolution

d21f888

Added quickfix for unresolved field.

b45cfe1

Fix Tests + Fix Warnings

6027eae

Added tests, added Union Support, and code cleanup

255ba69

Typo

4f0bc1a

Starting Fix for cfg stripping

f45b080

Compress file text using lz4 in salsa

02b6c18

Stop using an Arc when setting the file text

0f43b55

Fix test

a12ccd5

Add cfg_attr and cleanup code

79f2651

Clippy Fix

948a2de

Clippy fixes

717ba1d

Merge commit '574e23ec508064613783cba3d1833a95fd9a5080' into sync-fro…

aa74d57

…m-ra

Bring back in-rust-tree feature to ide

ce64207

Merge branch 'master' into sync-from-rust3

fb9744e

Fix import

f65fe4e

Auto merge of rust-lang#16807 - lnicola:sync-from-rust3, r=lnicola

0931361

minor: sync last two releases from downstream Turns out I made quite a mess on the last two syncs, and this PR is a mess too, but I hope it's fine.

internal: Remove synstructure const hack support

558feea

internal: Treat the self param as different from patterns when lowering

458f4a2

Add method resolution deref inference var test

c679482

Auto merge of rust-lang#16784 - Veykril:body-invalid, r=Veykril

1069f57

internal: Remove synstructure const hack support The latest version of it no longer emits these

Veykril and others added 4 commits March 16, 2024 17:49

fix: Fix wrong where clause rendering on hover

d69a81f

Auto merge of rust-lang#16856 - Veykril:macarons, r=Veykril

b94c285

fix: Fix wrong where clause rendering on hover We were not accounting for proper newline indentation in some places making the hover look weird (or just straight up wrong for type aliases)

Merge commit '5ecace48f693afaa6adf8cb23086b651db3aec96' into sync-fro…

20ecf07

…m-ra

rustbot assigned Mark-Simulacrum Mar 17, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024

Auto merge of rust-lang#122628 - lnicola:sync-from-ra, r=lnicola

8e918b7

Subtree update of `rust-analyzer`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 17, 2024

bors merged commit a0c20d5 into rust-lang:master Mar 17, 2024
12 checks passed

rustbot added this to the 1.79.0 milestone Mar 17, 2024

lnicola deleted the sync-from-ra branch March 17, 2024 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #122628

Subtree update of `rust-analyzer` #122628

lnicola commented Mar 17, 2024

rustbot commented Mar 17, 2024

rustbot commented Mar 17, 2024

lnicola commented Mar 17, 2024

rustbot commented Mar 17, 2024

lnicola commented Mar 17, 2024

bors commented Mar 17, 2024

bors commented Mar 17, 2024

rust-log-analyzer commented Mar 17, 2024

bors commented Mar 17, 2024

lnicola commented Mar 17, 2024

bors commented Mar 17, 2024

bors commented Mar 17, 2024

rust-timer commented Mar 17, 2024

Subtree update of rust-analyzer #122628

Subtree update of rust-analyzer #122628

Conversation

lnicola commented Mar 17, 2024

rustbot commented Mar 17, 2024

rustbot commented Mar 17, 2024

lnicola commented Mar 17, 2024

rustbot commented Mar 17, 2024

lnicola commented Mar 17, 2024

bors commented Mar 17, 2024

bors commented Mar 17, 2024

rust-log-analyzer commented Mar 17, 2024

bors commented Mar 17, 2024

lnicola commented Mar 17, 2024

bors commented Mar 17, 2024

bors commented Mar 17, 2024

rust-timer commented Mar 17, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Subtree update of `rust-analyzer` #122628

Subtree update of `rust-analyzer` #122628