Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Fix the f16 and f128 feature gate regression #123445

Closed
wants to merge 2 commits into from
Closed

[beta] Fix the f16 and f128 feature gate regression #123445

wants to merge 2 commits into from

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Apr 4, 2024

Apply the fix from #123307 (comment).

Fixes #123282

@tgross35
Update f16 and f128 tests to run on both 2015 and 2018 editions
07ed445 
Reproduce the bug from <rust-lang#123282>
that indicates this feature gate hits edition-dependent resolution paths.
Resolution changed in edition 2018, so test that as well.

(cherry picked from commit 9a7b176)
@tgross35
Fix f16 and f128 feature gates in editions other than 2015
356bb13 
Fixes rust-lang#123282

Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
(cherry picked from commit 5afe072)
@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 4, 2024
@tgross35 tgross35 mentioned this pull request Apr 4, 2024
Closed
@tgross35
Copy link
Contributor Author

tgross35 commented Apr 4, 2024

r? @Mark-Simulacrum

@rustbot rustbot assigned Mark-Simulacrum and unassigned fee1-dead Apr 4, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Apr 4, 2024 •
edited
Loading

@rustbot label +F-f16_and_f128 +beta-nominated

Not sure who makes beta decisions, or if the nomination label means anything since this PR already targets that channel...

@rustbot rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 4, 2024
@Noratrieb
Copy link
Member

The way backports usually work is that we label the original PR, and it then gets reviewed in the weekly compiler triage meeting (today). The backport PRs against beta are then usually made by cuviper or other release team members.
But doing it like this should work too, and be seen and reviewed today.

@apiraino
Copy link
Contributor

apiraino commented Apr 4, 2024

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 4, 2024
@cuviper
Copy link
Member

cuviper commented Apr 4, 2024

Our usual backporting query only looks at closed (merged) PRs, so it doesn't show this one. But now that I've seen it, I'll include this in the aggregate backport PR I'm creating.

@cuviper cuviper mentioned this pull request Apr 4, 2024
Merged
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 4, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Apr 4, 2024

Thanks all, think I can close this since it's going in through Josh's tree

@tgross35 tgross35 closed this Apr 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2024
@bors
Auto merge of rust-lang#123466 - cuviper:beta-next, r=cuviper
ad9b3c8 
[beta] backports

- Fix f16 and f128 feature gates in editions other than 2015 rust-lang#123307 / rust-lang#123445
- Update to LLVM 18.1.2 rust-lang#122772
- unix fs: Make hurd using explicit new rather than From rust-lang#123057
- Don't inherit codegen attrs from parent static rust-lang#123310
- Make sure to insert Sized bound first into clauses list rust-lang#123302

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 6, 2024
@bors
Auto merge of rust-lang#123466 - cuviper:beta-next, r=cuviper
9eff510 
[beta] backports

- Fix f16 and f128 feature gates in editions other than 2015 rust-lang#123307 / rust-lang#123445
- Update to LLVM 18.1.2 rust-lang#122772
- unix fs: Make hurd using explicit new rather than From rust-lang#123057
- Don't inherit codegen attrs from parent static rust-lang#123310
- Make sure to insert Sized bound first into clauses list rust-lang#123302

r? cuviper
@tgross35 tgross35 deleted the f16-f128-feature-gate-cherry-pick branch April 9, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tgross35 @rustbot @Noratrieb @apiraino @cuviper @Mark-Simulacrum @fee1-dead