CFI: Recursively transform predicates in ty::Dynamic rather than using identity (Redux)
#123524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're using a type folder, the arguments in predicates are processed automatically - we don't need to descend manually. We also want to keep projection clauses around, and this does so.
rustbot
added
PG-exploit-mitigations
|
why did you open this as a separate PR rather than let me just rebase #123045? lol |
|
Sure, I'll close this. |
|
Re-opened no longer on top of #123521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're using
TypeFolder, avoiding the instantiation at identity and keeping theProjectionclauses is as simple as not transformingty::Dynamic- the folder will recursively visit the args for us where needed.This is intended to have the same effect as #123045
This is currently on top of #123521, but if it appears that won't land, it can easily be rebased onto master. Setting as draft until #123521 is merged or rejected.
r? compiler-errors