Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos in comments #124322

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore: fix some typos in comments #124322

merged 1 commit into from
Apr 25, 2024

Conversation

whosehang
Copy link
Contributor

No description provided.

Signed-off-by: whosehang <whosehang@outlook.com>
@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 24, 2024

📌 Commit 65d7c1d has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124322 (chore: fix some typos in comments)
 - rust-lang#124326 (tests: remove few ignore-stage2)
 - rust-lang#124333 (Improve diagnostic for unknown `--print` request)
 - rust-lang#124334 (Strengthen tracking issue policy with consequences)
 - rust-lang#124335 (Stabilize `std::path::absolute`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124322 (chore: fix some typos in comments)
 - rust-lang#124333 (Improve diagnostic for unknown `--print` request)
 - rust-lang#124334 (Strengthen tracking issue policy with consequences)
 - rust-lang#124335 (Stabilize `std::path::absolute`)
 - rust-lang#124351 (fix typo in binary_heap docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1771390 into rust-lang:master Apr 25, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2024
Rollup merge of rust-lang#124322 - whosehang:master, r=Nilstrieb

chore: fix some typos in comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants