Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle the targets that are missing in stage0 #124461

Merged
merged 1 commit into from
May 3, 2024

Conversation

onur-ozkan
Copy link
Member

During sanity checks, we search for target names to determine if they exist in the compiler's built-in target list (rustc --print target-list). While a target name may be present in the stage2 compiler, it might not yet be included in stage0. This PR handles that difference.

Follow-up of #123546

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Apr 28, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 28, 2024
@pietroalbini
Copy link
Member

r? @pietroalbini
@bors r+

It would be nice to add a check somewhere that errors out if one of the targets in STAGE0_MISSING_TARGETS is actually present in stage0, to force us to keep that list up to date, but let's do this in a followup. #123546 broke all downstreams who add extra targets (like Ferrocene does), and we should unblock them ASAP.

@bors
Copy link
Contributor

bors commented May 3, 2024

📌 Commit 57a5f34 has been approved by pietroalbini

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2024
@bjorn3
Copy link
Member

bjorn3 commented May 3, 2024

I still think parsing the target list in rustc_target is a better idea, but 🤷

bors added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#124461 (handle the targets that are missing in stage0)
 - rust-lang#124492 (Generalize `adjust_from_tcx` for `Allocation`)
 - rust-lang#124588 (Use `ObligationCtxt` in favor of `TraitEngine` in many more places)
 - rust-lang#124612 (Add support for inputing via stdin with run-make-support)
 - rust-lang#124613 (Allow fmt to run on rmake.rs test files)
 - rust-lang#124649 (Fix HorizonOS build broken by rust-lang#124210)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 819a5f0 into rust-lang:master May 3, 2024
10 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2024
Rollup merge of rust-lang#124461 - onur-ozkan:followup-123546, r=pietroalbini

handle the targets that are missing in stage0

During sanity checks, we search for target names to determine if they exist in the compiler's built-in target list (`rustc --print target-list`). While a target name may be present in the stage2 compiler, it might not yet be included in stage0. This PR handles that difference.

Follow-up of rust-lang#123546
@onur-ozkan onur-ozkan deleted the followup-123546 branch May 3, 2024 17:42
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2024
…albini

keep the `STAGE0_MISSING_TARGETS` list updated

Implements rust-lang#124461 (comment).

r? pietroalbini
RalfJung pushed a commit to RalfJung/miri that referenced this pull request May 22, 2024
keep the `STAGE0_MISSING_TARGETS` list updated

Implements rust-lang/rust#124461 (comment).

r? pietroalbini
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request May 24, 2024
keep the `STAGE0_MISSING_TARGETS` list updated

Implements rust-lang/rust#124461 (comment).

r? pietroalbini
bors added a commit to rust-lang/rust-analyzer that referenced this pull request Jun 20, 2024
keep the `STAGE0_MISSING_TARGETS` list updated

Implements rust-lang/rust#124461 (comment).

r? pietroalbini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants