Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #124558

Merged
merged 15 commits into from
Apr 30, 2024
Merged

Rollup of 3 pull requests #124558

merged 15 commits into from
Apr 30, 2024

Commits on Apr 27, 2024

  1. Mention Both HRTB and Generic Lifetime in E0637 documentation

    Also, small grammar fix.
    veera-sivarajan committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    26ed429 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    4814fd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ce258f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6b3e20 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    99e036b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f3e05d1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7418aa1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1ab34f0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    52e9a23 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    6341935 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2088de2 View commit details
    Browse the repository at this point in the history
  3. Remove redundant union check in `KnownPanicsLint const prop

    because we are already marking unions `NoPropagation` in
    `CanConstProp::check()`. That is enough to prevent any attempts
    at const propagating unions and this second check is not needed.
    
    Also improve a comment in `CanConstProp::check()`
    gurry committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    741d40f View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#123247 - veera-sivarajan:fix-error-code-E06…

    …37-example-code, r=fmease
    
    Mention Both HRTB and Generic Lifetime Param in `E0637` documentation
    
    The compiler (rustc 1.77.0) error for `and_without_explicit_lifetime()` in the erroneous code example suggests using a HRTB. But, the corrected example uses an explicit lifetime parameter.
    
    This PR fixes it so that the documentation and the compiler suggestion for error code `E0637` are consistent with each other.
    matthiaskrgr committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7427812 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#124511 - nnethercote:rm-extern-crates, r=fe…

    …e1-dead
    
    Remove many `#[macro_use] extern crate foo` items
    
    This requires the addition of more `use` items, which often make the code more verbose. But they also make the code easier to read, because `#[macro_use]` obscures where macros are defined.
    
    r? `@fee1-dead`
    matthiaskrgr committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    784316e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#124550 - gurry:remove-redundant-code, r=oli…

    …-obk
    
    Remove redundant union check in `KnownPanicsLint` const prop
    
    Removes the below check which prevents unions from being const propagated:https://github.com/rust-lang/rust/blob/f9dca46218d4b8efa062aec4fd0820cbb4942aa2/compiler/rustc_mir_transform/src/known_panics_lint.rs#L587-L594
    
    It is not needed because after PR rust-lang#124504 we mark unions as `NoPropagation` over here: https://github.com/rust-lang/rust/blob/f9dca46218d4b8efa062aec4fd0820cbb4942aa2/compiler/rustc_mir_transform/src/known_panics_lint.rs#L899-L902 which is enough to prevent them from being const propagated.
    matthiaskrgr committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    5a4e83c View commit details
    Browse the repository at this point in the history