Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LazyLock to "Higher-level sync" docs #125686

Closed
wants to merge 1 commit into from
Closed

Conversation

pitaj
Copy link
Contributor

@pitaj pitaj commented May 28, 2024

Partially addresses #125615

There's room for improvement but I figured it would be good to get something in there sooner rather than later.

@pitaj pitaj marked this pull request as ready for review May 28, 2024 22:21
@rustbot
Copy link
Collaborator

rustbot commented May 28, 2024

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 28, 2024
@jhpratt
Copy link
Member

jhpratt commented May 28, 2024

While the docs current state "global variable" and that is probably the most common use case, it is very much permitted to use these with locals. r=me when changed.

@workingjubilee
Copy link
Member

I had worked out a PR (#125696) to fully address that issue and another, and my wording for this specific part is in 66ee452

Feel free to reappropriate it in part, and I'm happy to drop that commit if this lands.

@bors
Copy link
Contributor

bors commented Jun 4, 2024

☔ The latest upstream changes (presumably #125989) made this pull request unmergeable. Please resolve the merge conflicts.

@pitaj pitaj closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants