Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #126369

Closed
wants to merge 33 commits into from

Commits on Jun 12, 2024

  1. Configuration menu
    Copy the full SHA
    17b0771 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80408e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    59acd23 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2ac5faa View commit details
    Browse the repository at this point in the history
  5. add is_none_or

    RalfJung committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    63bdcaa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4c208ac View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ffe5439 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6d93626 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4b809b9 View commit details
    Browse the repository at this point in the history
  10. docs(rustc): Link unexpected_cfgs to the Cargo.toml docs

    This is the first time we have a lint with configuration exposed in
    `Cargo.toml`.
    When this was done, interest was expressed in using this for other cases
    in the future.
    To this end, we need to make the documentation for the lint
    configuration discoverable from the documentation for that lint.
    epage committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9232bd2 View commit details
    Browse the repository at this point in the history
  11. docs(rustc): De-emphasize --cfg/--check-cfg note

    At the suggestion of @Urgau
    epage committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    e171e64 View commit details
    Browse the repository at this point in the history
  12. std::unix::fs::link using direct linkat call for Solaris and macOs.

    Since we support solaris 11 and macOs Sierra as minimum, we can get rid
    of the runtime overhead.
    devnexen committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    075f068 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    52b2c88 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b0c1474 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    44040a0 View commit details
    Browse the repository at this point in the history
  16. Make try_from_target_usize method public

    There is now no way to create a TyConst from an integer, so I propose making this method public unless there was a reason for keeping it otherwise.
    artemagvanian committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    46391b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Configuration menu
    Copy the full SHA
    c453c82 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    93d83c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8d12d9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c0348a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1fa19c View commit details
    Browse the repository at this point in the history
  6. Rebase fallout

    compiler-errors committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ae24ebe View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125165 - Oneirical:pgo-branch-weights, r=ji…

    …eyouxu
    
    Migrate `run-make/pgo-branch-weights` to `rmake`
    
    Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
    
    This is a scary one and I expect things to break. Set as draft, because this isn't ready.
    
    - [x] There is this comment here, which suggests the test is excluded from the testing process due to a platform specific issue? I can't see anything here that would cause this test to not run...
    > // FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
    // properly. Since we only have GCC on the CI ignore the test for now."
    
    EDIT: This is specific to Windows-gnu.
    
    - [x] The Makefile has this line:
    ```
    ifneq (,$(findstring x86,$(TARGET)))
    COMMON_FLAGS=-Clink-args=-fuse-ld=gold
    ```
    I honestly can't tell whether this is checking if the target IS x86, or IS NOT. EDIT: It's checking if it IS x86.
    
    - [x] I don't know why the Makefile was trying to pass an argument directly in the Makefile instead of setting that "aaaaaaaaaaaa2bbbbbbbbbbbb2bbbbbbbbbbbbbbbbcc" input as a variable in the Rust program directly. I changed that, let me know if that was wrong.
    
    - [x] Trying to rewrite `cat "$(TMPDIR)/interesting.ll" | "$(LLVM_FILECHECK)" filecheck-patterns.txt` resulted in some butchery. For starters, in `tools.mk`, LLVM_FILECHECK corrects its own backslashes on Windows distributions, but there is no further mention of it, so I assume this is a preset environment variable... but is it really? Then, the command itself uses a Standard Input and a passed input file as an argument simultaneously, according to the [documentation](https://llvm.org/docs/CommandGuide/FileCheck.html#synopsis).
    
    try-job: aarch64-gnu
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ae73d9d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#125674 - Oneirical:another-day-another-test…

    …, r=jieyouxu
    
    Rewrite `symlinked-extern`, `symlinked-rlib` and `symlinked-libraries` `run-make` tests in `rmake.rs` format
    
    Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
    
    try-job: x86_64-msvc
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    b1a6d44 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#125688 - compiler-errors:alias-reporting, r…

    …=lcnr
    
    Walk into alias-eq nested goals even if normalization fails
    
    Somewhat broken due to the fact that we don't handle aliases well, nor do we handle ambiguities well. Still want to put up this incremental piece, since it improves type errors for projections whose trait refs are not satisfied.
    
    r? lcnr
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    dd6df05 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#126142 - compiler-errors:trait-ref-split, r…

    …=jackh726
    
    Harmonize using root or leaf obligation in trait error reporting
    
    When rust-lang#121826 changed the error reporting to use root obligation and not the leafmost obligation, it didn't actually make sure that all the other diagnostics helper functions used the right obligation.
    
    Specifically, when reporting similar impl candidates we are looking for impls of the root obligation, but trying to match them against the trait ref of the leaf obligation.
    
    This does a few other miscellaneous changes. There's a lot more clean-up that could be done here, but working with this code is really grief-inducing due to how messy it has become over the years. Someone really needs to show it love. 😓
    
    r? `@estebank`
    
    Fixes rust-lang#126129
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    c315b05 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#126303 - sancho20021:patch-1, r=compiler-er…

    …rors
    
    Urls to docs in rust_hir
    
    <!--
    If this PR is related to an unstable feature or an otherwise tracked effort,
    please link to the relevant tracking issue here. If you don't know of a related
    tracking issue or there are none, feel free to ignore this.
    
    This PR will get automatically assigned to a reviewer. In case you would like
    a specific user to review your work, you can assign it to them by using
    
        r​? <reviewer name>
    -->
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    68d72e9 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b1b9961 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#126337 - oli-obk:nested_gat_opaque, r=lcnr

    Add test for walking order dependent opaque type behaviour
    
    r? ``@lcnr``
    
    adding the test for your comment here: https://github.com/rust-lang/rust/pull/122366/files#r1521124754
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    cc940ea View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#126351 - devnexen:to_sol11_upd, r=ChrisDenton

    std::unix::fs::link using direct linkat call for Solaris.
    
    Since we support solaris 11 as minimum, we can get rid of the runtime overhead.
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1315e47 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#126353 - compiler-errors:move-match, r=lcnr

    Move `MatchAgainstFreshVars` to old solver
    
    Small change I noticed when trying to uplift the relations to the new trait solver.
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    5a9bfb9 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#126356 - epage:check-cfg, r=Urgau

    docs(rustc): Improve discoverable of Cargo docs
    
    In preparing Cargo's blog post for 1.80, I tried to find the documentation for the lint configuration and I couldn't.  The link is only visible from the lint itself, which isn't where I started, and the side bar, which was collapsed for me.
    
    The first place I went was the docs for `unexpected_cfgs` because this is configuration for that lint.  If using lint configuration were a one off, I could see skipping it here.  However, when we discussed this with at least one T-compiler member, there was interest in using this for other lints in the future.  To that end, it seems like we should be exposing this with the lint itself.
    
    The second place I checked was the `check-cfg` documentation.  This now has a call out for the sub-page.
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    574c413 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#126362 - artemagvanian:patch-1, r=celinval

    Make `try_from_target_usize` method public
    
    There is now no way to create a TyConst from an integer, so I propose making this method public unless there was a reason for keeping it otherwise.
    workingjubilee committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f16bd4e View commit details
    Browse the repository at this point in the history