Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Mac Catalyst targets to Tier 2, and ship with rustup #126450

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Jun 14, 2024

Promote the Mac Catalyst targets x86_64-apple-ios-macabi and aarch64-apple-ios-macabi to Tier 2, as per the MCP (see that for motivation and details).

These targets are now also distributed with rustup, although without the sanitizer runtime, as that currently has trouble building, see #129069.

@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 14, 2024
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2024

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

1 similar comment
@rustbot
Copy link
Collaborator

rustbot commented Jun 14, 2024

Failed to set assignee to ghost: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

r? compiler

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 14, 2024
@madsmtm
Copy link
Contributor Author

madsmtm commented Jul 15, 2024

The MCP has been accepted, so:

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2024
@madsmtm madsmtm marked this pull request as ready for review July 15, 2024 14:24
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

@petrochenkov
Copy link
Contributor

r? infra

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2024

📌 Commit 64ec270 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2024
…rk-Simulacrum

Promote Mac Catalyst targets to Tier 2, and ship with rustup

Promote the Mac Catalyst targets `x86_64-apple-ios-macabi` and `aarch64-apple-ios-macabi` to Tier 2.

Draft until [the MCP](rust-lang/compiler-team#761) finishes (see that for motivation).

`@rustbot` author
r? `@ghost`
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@madsmtm
Copy link
Contributor Author

madsmtm commented Aug 13, 2024

Still have to do some more digging, but it seems like the issue is that we don't pass the iOSSupport libraries to CMake, as is otherwise done.

I'll try to fix this in the cmake crate, but after that, we'll still have to update bootstrap to use the newer cmake.

Linking https://github.com/leetal/ios-cmake to myself for later (might contain some of the relevant CMake configuration for this).

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

- aarch64-apple-ios-macabi
- x86_64-apple-ios-macabi
@rust-log-analyzer

This comment has been minimized.

@madsmtm
Copy link
Contributor Author

madsmtm commented Aug 14, 2024

I've disabled the sanitizer runtimes on Mac Catalyst for now and opened #129069 for that, to get this moving forwards.
@rustbot ready

I don't think it'll fail to merge again, I've tested it by replacing the pr step in jobs.yml with the dist-apple-various step I've changed, and got a successful build here (didn't actually complete, I think since it didn't upload, but the build itself completed).

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 18, 2024

📌 Commit 3ed63dd has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
@bors
Copy link
Contributor

bors commented Aug 18, 2024

⌛ Testing commit 3ed63dd with merge 6de928d...

@bors
Copy link
Contributor

bors commented Aug 18, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 6de928d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2024
@bors bors merged commit 6de928d into rust-lang:master Aug 18, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 18, 2024
@madsmtm madsmtm deleted the promote-mac-catalyst branch August 18, 2024 18:47
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6de928d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.2% [0.2%, 0.3%] 2
Regressions ❌
(secondary)
0.2% [0.2%, 0.3%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.2%, 0.3%] 2

Max RSS (memory usage)

Results (primary 2.7%, secondary -4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.7% [2.5%, 2.9%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.3% [-4.7%, -3.9%] 2
All ❌✅ (primary) 2.7% [2.5%, 2.9%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.389s -> 751.033s (-0.05%)
Artifact size: 339.14 MiB -> 339.18 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Aug 18, 2024
@lqd
Copy link
Member

lqd commented Aug 18, 2024

obviously noise

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants