Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #126590

Closed
wants to merge 8 commits into from
Closed

Rollup of 3 pull requests #126590

wants to merge 8 commits into from

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

cjgillot and others added 8 commits June 17, 2024 10:09
@cjgillot
Do not ICE in privacy when type inference fails.
9074427
@oli-obk
Add regression test
97372c8
@oli-obk
Remove an unused validation error variant
4e5dfb6
@oli-obk
Use subtyping instead of equality, since method resolution also uses …
94f5495 
…subtyping
@oli-obk
Remove windows-specific copy of test
3e6e6b1
@GuillaumeGomez
Rollup merge of rust-lang#126128 - oli-obk:method_ice, r=lcnr
ca70f3e 
Consistently use subtyping in method resolution

fixes rust-lang#126062

An earlier version of this PR modified how we compute variance, but the root cause was an inconsistency between the usage of `eq` and `sub`, where we assumed that the latter passing implies the former will pass.

r? `@compiler-errors`
@GuillaumeGomez
Rollup merge of rust-lang#126577 - oli-obk:static_valtrees, r=RalfJung
879c151 
const_refs_to_static test and cleanup

r? `@RalfJung`

test the existing behaviour of adt_const_params combined with const_refs_to_static.

also remove a dead error variant about consts referring to statics
@GuillaumeGomez
Rollup merge of rust-lang#126584 - cjgillot:issue-122736, r=michaelwo…
3b3ee43 
…erister

Do not ICE in privacy when type inference fails.

Fixes rust-lang#122736
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 17, 2024
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=3 rollup=never

@bors
Copy link
Contributor

bors commented Jun 17, 2024

📌 Commit 3b3ee43 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2024
@matthiaskrgr
Copy link
Member

#126128 is already testing

@GuillaumeGomez GuillaumeGomez deleted the rollup-ps2dt3p branch June 17, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @bors @matthiaskrgr @rustbot @cjgillot @oli-obk