Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate include_bytes_deps, optimization-remarks-dir-pgo, optimization-remarks-dir, issue-40535 and rmeta-preferred run-make tests to rmake #126709

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Migrate include_bytes_deps, optimization-remarks-dir-pgo, optimization-remarks-dir, issue-40535 and rmeta-preferred run-make tests to rmake #126709

merged 6 commits into from
Jul 5, 2024

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jun 19, 2024 •
edited by jieyouxu
Loading

Part of #121876 and the associated Google Summer of Code project.

Needs BSD tryjob.

try-job: aarch64-apple
try-job: x86_64-msvc
try-job: armhf-gnu
try-job: test-various

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 19, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu mentioned this pull request Jun 19, 2024
Open
@jieyouxu

This comment was marked as outdated.

Sign in to view
@bors

This comment was marked as outdated.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2024
@jieyouxu

This comment was marked as outdated.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2024
@jieyouxu
Copy link
Member

@bors delegate+ (for try job only)

@bors
Copy link
Contributor

bors commented Jun 19, 2024

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@Oneirical
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2024
@bors
Auto merge of rust-lang#126709 - Oneirical:exitestial-crisis, r=<try>
617b52f 
Migrate `include_bytes_deps`, `optimization-remarks-dir-pgo`, `optimization-remarks-dir`, `issue-40535` and `rmeta-preferred` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Needs BSD tryjob.

try-job: dist-x86_64-freebsd
@bors
Copy link
Contributor

bors commented Jun 19, 2024

⌛ Trying commit 61b9273 with merge 617b52f...

@bors
Copy link
Contributor

bors commented Jun 19, 2024

☀️ Try build successful - checks-actions
Build commit: 617b52f (617b52fa98c65d42b0841c6a7fe0046b44e38f98)

@Oneirical
Copy link
Contributor Author

@rustbot review (all I did was remove the disabled ignore-bsd as it succeeded in the try-job)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2024
jieyouxu
jieyouxu approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a tiny nit, then r=me

tests/run-make/metadata-only-crate-no-ice/rmake.rs Outdated Show resolved Hide resolved
@jieyouxu
Copy link
Member

@bors delegate+

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 3, 2024
@bors
Auto merge of rust-lang#126709 - Oneirical:exitestial-crisis, r=<try>
6eab187 
Migrate `include_bytes_deps`, `optimization-remarks-dir-pgo`, `optimization-remarks-dir`, `issue-40535` and `rmeta-preferred` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Needs BSD tryjob.

try-job: aarch64-apple
try-job: x86_64-msvc
try-job: armhf-gnu
try-job: test-various
@bors
Copy link
Contributor

bors commented Jul 3, 2024

⌛ Trying commit 2496742 with merge 6eab187...

@bors
Copy link
Contributor

bors commented Jul 3, 2024

☀️ Try build successful - checks-actions
Build commit: 6eab187 (6eab1875aa0e06eed59f25e3197a458335546dc3)

@Oneirical
Copy link
Contributor Author

@bors r=@jieyouxu

@bors
Copy link
Contributor

bors commented Jul 3, 2024

📌 Commit 2496742 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2024
@Oneirical Oneirical mentioned this pull request Jul 3, 2024
Merged
@bors
Copy link
Contributor

bors commented Jul 3, 2024

☔ The latest upstream changes (presumably #127044) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2024
@Oneirical
Copy link
Contributor Author

@bors r=@jieyouxu

@bors
Copy link
Contributor

bors commented Jul 4, 2024

📌 Commit 3ea36f5 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2024
@Oneirical Oneirical mentioned this pull request Jul 4, 2024
Merged
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 5, 2024
@bors
Auto merge of rust-lang#127360 - GuillaumeGomez:rollup-f0zs1qr, r=Gui…
11dd90f 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#124290 (DependencyList: removed outdated comment)
 - rust-lang#126709 (Migrate `include_bytes_deps`, `optimization-remarks-dir-pgo`, `optimization-remarks-dir`, `issue-40535` and `rmeta-preferred` `run-make` tests to rmake)
 - rust-lang#127214 (Use the native unwind function in miri where possible)
 - rust-lang#127320 (Update windows-bindgen to 0.58.0)
 - rust-lang#127349 (Tweak `-1 as usize` suggestion)
 - rust-lang#127352 (coverage: Rename `mir::coverage::BranchInfo` to `CoverageInfoHi`)
 - rust-lang#127359 (Improve run make llvm ident code)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e66f4d3 into rust-lang:master Jul 5, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 5, 2024
@bors
Copy link
Contributor

bors commented Jul 5, 2024

⌛ Testing commit 3ea36f5 with merge 11dd90f...

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 5, 2024
@rust-timer
Unrolled build for rust-lang#126709
46f168b 
Rollup merge of rust-lang#126709 - Oneirical:exitestial-crisis, r=jieyouxu

Migrate `include_bytes_deps`, `optimization-remarks-dir-pgo`, `optimization-remarks-dir`, `issue-40535` and `rmeta-preferred` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Needs BSD tryjob.

try-job: aarch64-apple
try-job: x86_64-msvc
try-job: armhf-gnu
try-job: test-various
@Oneirical Oneirical deleted the exitestial-crisis branch July 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Oneirical @rustbot @rust-log-analyzer @jieyouxu @bors