Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore run-make tests that use symlink on Windows and adjust symlink wrapper #126846

Closed
wants to merge 2 commits into from
Closed

Ignore run-make tests that use symlink on Windows and adjust symlink wrapper #126846

wants to merge 2 commits into from

Commits on Jun 23, 2024

  1. run-make-support: panic on symlink wrapper usage on Windows 

    symlink creation is a priviledged operation on Windows that is normally
not enabled on user machines. It is enabled in CI, however. So let's
not make it easier to create symlinks on Windows.
    @jieyouxu
    jieyouxu committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    e012db5 View commit details
    Browse the repository at this point in the history

  2. tests: mark as ignore-windows because symlink usage

    @jieyouxu
    jieyouxu committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    b7cfc9d View commit details
    Browse the repository at this point in the history