Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate extern-flag-pathless, silly-file-names, metadata-dep-info, cdylib-fewer-symbols and symbols-include-type-name run-make tests to rmake #127006

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Migrate extern-flag-pathless, silly-file-names, metadata-dep-info, cdylib-fewer-symbols and symbols-include-type-name run-make tests to rmake #127006

merged 5 commits into from
Jul 10, 2024

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Jun 26, 2024 •
edited
Loading

Part of #121876 and the associated Google Summer of Code project.

cdylib-fewer-symbols demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time)

try-job: x86_64-gnu-distcheck
try-job: x86_64-msvc
try-job: aarch64-apple

@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@Kobzol
Copy link
Contributor

Kobzol commented Jun 26, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 26, 2024
@bors
Auto merge of rust-lang#127006 - Oneirical:holmes-the-detestive, r=<try>
e598dbf 
Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

`cdylib-fewer-symbols` demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time)

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Jun 26, 2024

⌛ Trying commit d1b874b with merge e598dbf...

@Kobzol Kobzol mentioned this pull request Jun 26, 2024
Open
@bors
Copy link
Contributor

bors commented Jun 26, 2024

☀️ Try build successful - checks-actions
Build commit: e598dbf (e598dbf17b1e7ec54bc220c387ae6ace93db098f)

@Oneirical
Copy link
Contributor Author

Oneirical commented Jun 27, 2024 •
edited
Loading

Well, how cool is that? I think it's because llvm-readobj is more platform-agnostic than nm. FIXME statement removed.

@Kobzol
Copy link
Contributor

Kobzol commented Jun 28, 2024

Thanks!

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Jun 28, 2024

📌 Commit 53a7aee has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2024
@bors
Copy link
Contributor

bors commented Jun 30, 2024

⌛ Testing commit 53a7aee with merge 08ce4db...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@bors
Auto merge of rust-lang#127006 - Oneirical:holmes-the-detestive, r=Ko…
08ce4db 
…bzol

Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

`cdylib-fewer-symbols` demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time)

try-job: x86_64-msvc
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 30, 2024

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 6, 2024
@bors
Auto merge of rust-lang#127006 - Oneirical:holmes-the-detestive, r=Ko…
1600f03 
…bzol

Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

`cdylib-fewer-symbols` demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time)

try-job: x86_64-msvc
try-job: armhf-gnu
try-job: aarch64-apple
try-job: test-various
@bors
Copy link
Contributor

bors commented Jul 6, 2024

⌛ Testing commit ffc06a4 with merge 1600f03...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 6, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Jul 6, 2024

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2024
@Oneirical
Copy link
Contributor Author

Oneirical commented Jul 9, 2024 •
edited
Loading

@bors try (No privileges)
@rustbot review
Please retry, I think it will work now (I was printing all symbols, not only external symbols like nm -g does).

@bors
Copy link
Contributor

bors commented Jul 9, 2024

@Oneirical: 🔑 Insufficient privileges: not in try users

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jul 9, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 9, 2024
@bors
Auto merge of rust-lang#127006 - Oneirical:holmes-the-detestive, r=<try>
1f8750c 
Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

`cdylib-fewer-symbols` demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time)

try-job: x86_64-gnu-distcheck
try-job: x86_64-msvc
try-job: aarch64-apple
@bors
Copy link
Contributor

bors commented Jul 9, 2024

⌛ Trying commit d447321 with merge 1f8750c...

@bors
Copy link
Contributor

bors commented Jul 9, 2024

☀️ Try build successful - checks-actions
Build commit: 1f8750c (1f8750c4be84251450bf03f5fea390d8c3cbae7f)

@jieyouxu
Copy link
Member

Thanks!
@bors r=@Kobzol

@bors
Copy link
Contributor

bors commented Jul 10, 2024

📌 Commit d447321 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2024
@bors
Copy link
Contributor

bors commented Jul 10, 2024

⌛ Testing commit d447321 with merge 0fdfb61...

@bors
Copy link
Contributor

bors commented Jul 10, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 0fdfb61 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 10, 2024
@bors bors merged commit 0fdfb61 into rust-lang:master Jul 10, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 10, 2024
@bors bors mentioned this pull request Jul 10, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0fdfb61): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -4.3% [-4.3%, -4.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -4.3% [-4.3%, -4.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 704.785s -> 705.036s (0.04%)
Artifact size: 328.71 MiB -> 328.82 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Oneirical @rustbot @Kobzol @bors @rust-log-analyzer @ehuss @jieyouxu @rust-timer