Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match lowering: Clarify the main loop of the algorithm #127164

Merged
merged 7 commits into from
Jul 12, 2024
Merged

match lowering: Clarify the main loop of the algorithm #127164

merged 7 commits into from
Jul 12, 2024

Commits on Jul 9, 2024

  1. Move a function

    @Nadrieril
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5bf50e6 View commit details
    Browse the repository at this point in the history

  2. Factor out the special handling of or-patterns

    @Nadrieril
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    bff4d21 View commit details
    Browse the repository at this point in the history

  3. Move or-pattern expansion inside the main part of the algorithm

    @Nadrieril
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c5062f7 View commit details
    Browse the repository at this point in the history

  4. Don't try to save an extra block 

    This is preparation for the next commit.
    @Nadrieril
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8a222ff View commit details
    Browse the repository at this point in the history

  5. Factor out the "process remaining candidates" cases

    @Nadrieril
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fc40247 View commit details
    Browse the repository at this point in the history

  6. Return the otherwise_block instead of passing it as argument 

    This saves a few blocks and matches the common `unpack!` paradigm.
    @Nadrieril
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3e030b3 View commit details
    Browse the repository at this point in the history

  7. Address review comments

    @Nadrieril
    Nadrieril committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    42772e9 View commit details
    Browse the repository at this point in the history