Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Don't escape contents of headers #12737

Merged
merged 1 commit into from
Mar 6, 2014

Conversation

alexcrichton
Copy link
Member

Turns out sundown has already escaped this content for us, so there's no need
for us to escape it again.

Closes #12736

Turns out sundown has already escaped this content for us, so there's no need
for us to escape it again.

Closes rust-lang#12736
@flaper87
Copy link
Contributor

flaper87 commented Mar 6, 2014

LGTM

bors added a commit that referenced this pull request Mar 6, 2014
Turns out sundown has already escaped this content for us, so there's no need
for us to escape it again.

Closes #12736
@bors bors closed this Mar 6, 2014
@bors bors merged commit 9f6bced into rust-lang:master Mar 6, 2014
@alexcrichton alexcrichton deleted the issue-12736 branch March 7, 2014 01:45
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
Make test harness arguments configurable and not `--nocapture`.

* Added config `runnables.extraTestBinaryArgs` to control the args.
* The default is `--show-output` rather than `--nocapture` to prevent unreadable output when 2 or more tests fail or print output at once.
* Renamed variables in `CargoTargetSpec::runnable_args()` for clarity.

Fixes rust-lang#12737.

Suggested changelog info:

> New Features
>
> * add `rust-analyzer.runnables.extraTestBinaryArgs` to configure test harness options when running tests; replaces a previously hard-coded `--nocapture` option.

I'm not sure I made the right choices in vocabulary, between “binary”, “executable”, and “runnable”, and “launch” vs. “execute”, so let me know if I missed something to be consistent with in the naming and documentation.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
Make test harness arguments configurable and not `--nocapture`.

* Added config `runnables.extraTestBinaryArgs` to control the args.
* The default is `--show-output` rather than `--nocapture` to prevent unreadable output when 2 or more tests fail or print output at once.
* Renamed variables in `CargoTargetSpec::runnable_args()` for clarity.

Fixes rust-lang#12737.

Suggested changelog info:

> New Features
>
> * add `rust-analyzer.runnables.extraTestBinaryArgs` to configure test harness options when running tests; replaces a previously hard-coded `--nocapture` option.

I'm not sure I made the right choices in vocabulary, between “binary”, “executable”, and “runnable”, and “launch” vs. “execute”, so let me know if I missed something to be consistent with in the naming and documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting Issue in docs
4 participants