Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TrailingToken. #127842

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Remove TrailingToken. #127842

merged 1 commit into from
Jul 18, 2024

Commits on Jul 18, 2024

  1. Remove TrailingToken. 

    It's used in `Parser::collect_tokens_trailing_token` to decide whether
to capture a trailing token. But the callers actually know whether to
capture a trailing token, so it's simpler for them to just pass in a
bool.

Also, the `TrailingToken::Gt` case was weird, because it didn't result
in a trailing token being captured. It could have been subsumed by the
`TrailingToken::MaybeComma` case, and it effectively is in the new code.
    @nnethercote
    nnethercote committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    487802d View commit details
    Browse the repository at this point in the history