Migrate `remap-path-prefix-dwarf` `run-make` test to rmake #128410

Oneirical · 2024-07-30T20:28:54Z

Part of #121876 and the associated Google Summer of Code project.

Possibly my proudest branch name yet.

try-job: aarch64-apple
try-job: armhf-gnu
try-job: test-various
try-job: x86_64-gnu-llvm-18

rustbot · 2024-07-30T20:29:01Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-30T20:29:03Z

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu · 2024-07-30T22:16:28Z

@bors try

Migrate `remap-path-prefix-dwarf` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Possibly my proudest branch name yet. Please try: try-job: x86_64-mingw try-job: i686-msvc

bors · 2024-07-30T22:17:39Z

⌛ Trying commit faa6a16 with merge 39fd25d...

bors · 2024-07-31T00:05:27Z

💔 Test failed - checks-actions

bors · 2024-07-31T03:56:13Z

☔ The latest upstream changes (presumably #128075) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2024-07-31T16:07:44Z

Ignore restored, reason added. @rustbot review

bors · 2024-08-02T14:18:06Z

☔ The latest upstream changes (presumably #128352) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu

Nice

jieyouxu · 2024-08-03T00:27:11Z

tests/run-make/remap-path-prefix-dwarf/rmake.rs

+fn main() {
+    // The compiler is called with an *ABSOLUTE PATH* as input, and that absolute path *is* within
+    // the working directory of the compiler. We are remapping the path that contains `src`.
+    check_dwarf(DwarfTest {


Remark: this organization is very nice 👍

jieyouxu · 2024-08-03T00:30:18Z

@bors try

Migrate `remap-path-prefix-dwarf` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Possibly my proudest branch name yet. try-job: aarch64-apple try-job: armhf-gnu try-job: test-various try-job: x86_64-gnu-llvm-18

bors · 2024-08-03T00:31:29Z

⌛ Trying commit bc72f04 with merge 5975414...

bors · 2024-08-03T02:44:47Z

☀️ Try build successful - checks-actions
Build commit: 5975414 (597541447dbac0d2aafa502613a6181ef184c141)

jieyouxu · 2024-08-03T02:47:26Z

Cool.
@bors r+

…<try> Migrate `reproducible-build` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This will likely fail. Locally, rustc errors with `linker 'linker' not found` on line 36 while the file exists according to the dir-debug statement before it. If this gets fixed and the test passes, further developments may include: - [x] There may be some leftovers from each test - `test_in_tmpdir` may therefore be required. - [ ] Try jobs on all ignored architectures. - [x] A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of `rfs` and `rustc`. This is a little bit harder to do in this test considering the variability present in each test case. try-job: aarch64-apple try-job: test-various try-job: armhf-gnu try-job: dist-various-1

…<try> Migrate `reproducible-build` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This will likely fail. Locally, rustc errors with `linker 'linker' not found` on line 36 while the file exists according to the dir-debug statement before it. If this gets fixed and the test passes, further developments may include: - [x] There may be some leftovers from each test - `test_in_tmpdir` may therefore be required. - [ ] Try jobs on all ignored architectures. - [x] A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of `rfs` and `rustc`. This is a little bit harder to do in this test considering the variability present in each test case. # try-job: aarch64-apple try-job: test-various try-job: armhf-gnu try-job: dist-various-1 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#128616 (Don't inline tainted MIR bodies) - rust-lang#128804 (run-make: enable msvc for redundant-libs) - rust-lang#128823 (run-make: enable msvc for staticlib-dylib-linkage) - rust-lang#128824 (Update compiler-builtins version to 0.1.118) Failed merges: - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2024-08-11T03:30:54Z

@bors r- (needs a rebase)

jieyouxu · 2024-08-11T03:31:21Z

@bors delegate+ (r=me after rebase)

bors · 2024-08-11T03:31:24Z

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

Oneirical · 2024-08-12T14:27:46Z

@bors r=@jieyouxu

bors · 2024-08-12T14:27:50Z

📌 Commit fe52572 has been approved by jieyouxu

It is now in the queue for this repository.

…youxu Migrate `remap-path-prefix-dwarf` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Possibly my proudest branch name yet. try-job: aarch64-apple try-job: armhf-gnu try-job: test-various try-job: x86_64-gnu-llvm-18

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#127857 (Allow to customize `// TODO:` comment for deprecated safe autofix) - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake) - rust-lang#128828 (`-Znext-solver` caching) - rust-lang#128873 (Add windows-targets crate to std's sysroot) - rust-lang#129034 (Add `#[must_use]` attribute to `Coroutine` trait) - rust-lang#129049 (compiletest: Don't panic on unknown JSON-like output lines) - rust-lang#129050 (Emit a warning instead of an error if `--generate-link-to-definition` is used with other output formats than HTML) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake) - rust-lang#128759 (alloc: add ToString specialization for `&&str`) - rust-lang#128873 (Add windows-targets crate to std's sysroot) - rust-lang#129001 (chore(lib): Enhance documentation for core::fmt::Formatter's write_fm…) - rust-lang#129061 (Use `is_lang_item` more) - rust-lang#129062 (Remove a no-longer-true assert) r? `@ghost` `@rustbot` modify labels: rollup

…<try> Migrate `reproducible-build` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This will likely fail. Locally, rustc errors with `linker 'linker' not found` on line 36 while the file exists according to the dir-debug statement before it. If this gets fixed and the test passes, further developments may include: - [x] There may be some leftovers from each test - `test_in_tmpdir` may therefore be required. - [ ] Try jobs on all ignored architectures. - [x] A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of `rfs` and `rustc`. This is a little bit harder to do in this test considering the variability present in each test case. try-job: aarch64-apple try-job: aarch64-gnu try-job: armhf-gnu try-job: test-various try-job: dist-various-1 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

Rollup merge of rust-lang#128410 - Oneirical:dwarf-fortestress, r=jieyouxu Migrate `remap-path-prefix-dwarf` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Possibly my proudest branch name yet. try-job: aarch64-apple try-job: armhf-gnu try-job: test-various try-job: x86_64-gnu-llvm-18

…<try> Migrate `reproducible-build` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This will likely fail. Locally, rustc errors with `linker 'linker' not found` on line 36 while the file exists according to the dir-debug statement before it. If this gets fixed and the test passes, further developments may include: - [x] There may be some leftovers from each test - `test_in_tmpdir` may therefore be required. - [ ] Try jobs on all ignored architectures. - [x] A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of `rfs` and `rustc`. This is a little bit harder to do in this test considering the variability present in each test case. try-job: aarch64-apple try-job: aarch64-gnu try-job: armhf-gnu try-job: test-various try-job: dist-various-1 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

…<try> Migrate `reproducible-build` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This will likely fail. Locally, rustc errors with `linker 'linker' not found` on line 36 while the file exists according to the dir-debug statement before it. If this gets fixed and the test passes, further developments may include: - [x] There may be some leftovers from each test - `test_in_tmpdir` may therefore be required. - [ ] Try jobs on all ignored architectures. - [x] A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of `rfs` and `rustc`. This is a little bit harder to do in this test considering the variability present in each test case. // try-job: aarch64-apple // try-job: aarch64-gnu // try-job: armhf-gnu // try-job: test-various // try-job: dist-various-1 try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

…<try> Migrate `reproducible-build` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This will likely fail. Locally, rustc errors with `linker 'linker' not found` on line 36 while the file exists according to the dir-debug statement before it. If this gets fixed and the test passes, further developments may include: - [x] There may be some leftovers from each test - `test_in_tmpdir` may therefore be required. - [ ] Try jobs on all ignored architectures. - [x] A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of `rfs` and `rustc`. This is a little bit harder to do in this test considering the variability present in each test case. // try-job: x86_64-msvc // windows jobs passed in a prior run // try-job: x86_64-mingw // try-job: i686-msvc // try-job: i686-mingw try-job: aarch64-apple try-job: aarch64-gnu try-job: armhf-gnu try-job: test-various try-job: dist-various-1

…jieyouxu Migrate `reproducible-build` `run-make` test to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This will likely fail. Locally, rustc errors with `linker 'linker' not found` on line 36 while the file exists according to the dir-debug statement before it. If this gets fixed and the test passes, further developments may include: - [x] There may be some leftovers from each test - `test_in_tmpdir` may therefore be required. - [ ] Try jobs on all ignored architectures. - [x] A potential refactor with a struct and a custom function like rust-lang#128410 so this isn't just a huge stream of `rfs` and `rustc`. This is a little bit harder to do in this test considering the variability present in each test case. // try-job: x86_64-msvc // windows jobs passed in a prior run // try-job: x86_64-mingw // try-job: i686-msvc // try-job: i686-mingw try-job: aarch64-apple try-job: aarch64-gnu try-job: armhf-gnu try-job: test-various try-job: dist-various-1

rustbot assigned jieyouxu Jul 30, 2024

jieyouxu mentioned this pull request Jul 30, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Open

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2024

Oneirical force-pushed the dwarf-fortestress branch 2 times, most recently from 9f11c34 to 605159a Compare July 31, 2024 16:07

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2024

Oneirical mentioned this pull request Jul 31, 2024

Migrate reproducible-build run-make test to rmake #128456

Merged

3 tasks

Oneirical force-pushed the dwarf-fortestress branch from 605159a to bc72f04 Compare August 2, 2024 14:26

jieyouxu approved these changes Aug 3, 2024

View reviewed changes

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 6 pull requests #128765

Closed

matthiaskrgr mentioned this pull request Aug 9, 2024

Rollup of 4 pull requests #128863

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2024

rewrite remap-path-prefix-dwarf to rmake

fe52572

Oneirical force-pushed the dwarf-fortestress branch from c3e7dd4 to fe52572 Compare August 12, 2024 14:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 12, 2024

GuillaumeGomez mentioned this pull request Aug 13, 2024

Rollup of 7 pull requests #129057

Closed

matthiaskrgr mentioned this pull request Aug 14, 2024

Rollup of 6 pull requests #129076

Merged

bors merged commit 2cb5908 into rust-lang:master Aug 14, 2024
6 checks passed

rustbot added this to the 1.82.0 milestone Aug 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `remap-path-prefix-dwarf` `run-make` test to rmake #128410

Migrate `remap-path-prefix-dwarf` `run-make` test to rmake #128410

Oneirical commented Jul 30, 2024 •

edited by jieyouxu

Loading

rustbot commented Jul 30, 2024

rustbot commented Jul 30, 2024

jieyouxu commented Jul 30, 2024

bors commented Jul 30, 2024

This comment has been minimized.

bors commented Jul 31, 2024

bors commented Jul 31, 2024

Oneirical commented Jul 31, 2024

bors commented Aug 2, 2024

jieyouxu left a comment

jieyouxu Aug 3, 2024

jieyouxu commented Aug 3, 2024

bors commented Aug 3, 2024

bors commented Aug 3, 2024

jieyouxu commented Aug 3, 2024

jieyouxu commented Aug 11, 2024

jieyouxu commented Aug 11, 2024

bors commented Aug 11, 2024

Oneirical commented Aug 12, 2024

bors commented Aug 12, 2024

Migrate remap-path-prefix-dwarf run-make test to rmake #128410

Migrate remap-path-prefix-dwarf run-make test to rmake #128410

Conversation

Oneirical commented Jul 30, 2024 • edited by jieyouxu Loading

rustbot commented Jul 30, 2024

rustbot commented Jul 30, 2024

jieyouxu commented Jul 30, 2024

bors commented Jul 30, 2024

This comment has been minimized.

bors commented Jul 31, 2024

bors commented Jul 31, 2024

Oneirical commented Jul 31, 2024

bors commented Aug 2, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu Aug 3, 2024

Choose a reason for hiding this comment

jieyouxu commented Aug 3, 2024

bors commented Aug 3, 2024

bors commented Aug 3, 2024

jieyouxu commented Aug 3, 2024

jieyouxu commented Aug 11, 2024

jieyouxu commented Aug 11, 2024

bors commented Aug 11, 2024

Oneirical commented Aug 12, 2024

bors commented Aug 12, 2024

Migrate `remap-path-prefix-dwarf` `run-make` test to rmake #128410

Migrate `remap-path-prefix-dwarf` `run-make` test to rmake #128410

Oneirical commented Jul 30, 2024 •

edited by jieyouxu

Loading