Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update powerpc64-wrs-vxworks platform support docs #128545

Closed
wants to merge 0 commits into from

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Aug 2, 2024

Tracing issue: #126451
Though PowerPC targets are not an active consideration during VxWorks rust development for the workbench, tools are available in workbench to build rust for this target. Thus would be happy to help if anyone need it. Thank you.
r? @ChrisDenton

@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ChrisDenton (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2024

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@ChrisDenton
Copy link
Member

While you're updating this, I also notice some vxworks targets also have a ? in the std support column. Could you fill it out with either a or *? It's ok to use * if it's not something you're actively supporting.

@biabbas
Copy link
Contributor Author

biabbas commented Aug 2, 2024

While you're updating this, I also notice some vxworks targets also have a ? in the std support column. Could you fill it out with either a or *? It's ok to use * if it's not something you're actively supporting.

VxWorks does support std. But the std is not yet fully tested. It is dependent on a lot of unix code that is not yet tested for VxWorks, thus ? suits best for it.
For reference an issue that was seen in connect_timeout for vxworks: #127300
But I think we are close so I'll update it as per your suggestion.

@ChrisDenton
Copy link
Member

I think it's fine to give it a in that situation. Though maybe @Noratrieb has thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants