Adjust memchr pinning and run cargo update

[tgross35]

try-job: x86_64-mingw

Supersedes #129538

[rustbot]

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

[tgross35]

Running a try job because of #127890

@bors try

[bors]

⌛ Trying commit 95a0761 with merge fd4dc52...

[tgross35]

@bors try

[bors]

⌛ Trying commit 95a0761 with merge bf3d3ef...

[bors]

💔 Test failed - checks-actions

[tgross35]

Hm. I assume this comes from stacker making a change that brings in windows-sys 0.36.1, which is quite a bit older than the other versions we use

[tgross35]

@nagisa it looks like you maintain https://github.com/rust-lang/stacker, any clue if this is related?

[nagisa]

Sounds plausible enough. There's already a PR that bumps it on stacker side, so you'll be able to check this soon enough.

[tgross35]

Okay, I dropped doing a cargo update in the root repo. Let's try again.

@bors try

[bors]

⌛ Trying commit 47c2f97 with merge 60d700d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 60d700d (60d700d5439dd91cf6ad2fd0616f3eb6afe7fe4f)

[bors]

⌛ Testing commit 7f51490 with merge 3bc3fd9...

[rust-log-analyzer]

The job x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

warning: profiler_builtins@0.0.0: 1 warning generated.
[RUSTC-TIMING] corebenches test:true 59.847
[RUSTC-TIMING] coretests test:true 86.466
Build completed unsuccessfully in 0:53:57
make: *** [Makefile:106: ci-msvc-ps1] Error 1
  network time: Wed, 11 Sep 2024 10:51:06 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[ChrisDenton]

Maybe changing the lock file affects the cache in some way that makes this error more likely to be hit? It does seem incredibly frequent with this PR.

[tgross35]

Yeah I don’t know why this is so weird, especially after your partial fix. When I’m back at a computer I’ll just try splitting it into a separate PR for each lockfile.

That is an interesting datapoint for the Windows CI issue if it seems like caching affects things.

[ChrisDenton]

trying to see if this is still a problem, if so #130151 may eliminate one source of failure.

[ChrisDenton]

@bors retry

[bors]

⌛ Testing commit 7f51490 with merge 0f066db...

[rust-log-analyzer]

The job x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

warning: profiler_builtins@0.0.0: 1 warning generated.
[RUSTC-TIMING] corebenches test:true 59.401
[RUSTC-TIMING] coretests test:true 86.157
Build completed unsuccessfully in 0:54:05
make: *** [Makefile:106: ci-msvc-ps1] Error 1
  network time: Sun, 15 Sep 2024 18:25:10 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[ChrisDenton]

Sorry for using this PR as a kind of canary but I'd like to try just one more time:

@bors retry

[bors]

⌛ Testing commit 7f51490 with merge 2794692...

[tgross35]

Sorry for using this PR as a kind of canary but I'd like to try just one more time:

Still haven’t gotten around to splitting this up, so be my guest as much as needed :)

[rust-log-analyzer]

The job x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

warning: profiler_builtins@0.0.0: 1 warning generated.
[RUSTC-TIMING] corebenches test:true 59.259
[RUSTC-TIMING] coretests test:true 85.327
Build completed unsuccessfully in 0:53:53
make: *** [Makefile:106: ci-msvc-ps1] Error 1
  network time: Wed, 18 Sep 2024 21:49:48 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

[bors]

💔 Test failed - checks-actions

[workingjubilee]

PR's haunted.