-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize the map
/value
methods on ControlFlow
#130518
base: master
Are you sure you want to change the base?
Conversation
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
dd1caed
to
2de809f
Compare
This comment has been minimized.
This comment has been minimized.
2de809f
to
ce0541e
Compare
r? libs-api |
This comment has been minimized.
This comment has been minimized.
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
7c4c9ce
to
e7b5805
Compare
This comment has been minimized.
This comment has been minimized.
And fix the stability attribute on the `pub use` in `core::ops`.
e7b5805
to
4c8ea84
Compare
#[unstable(feature = "control_flow_enum", reason = "new API", issue = "75744")] | ||
#[stable(feature = "control_flow_enum_type", since = "1.55.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to draw attention to this update specifically. The type has been stable for a while https://blog.rust-lang.org/2021/09/09/Rust-1.55.0.html#stabilized-apis, so I guess this attribute just wasn't doing anything. I set the since
to the same old release as the type.
@rfcbot fcp merge |
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
And fix the stability attribute on the
pub use
incore::ops
.libs-api in #75744 (comment) seemed reasonably happy with naming for these, so let's try for an FCP.
Summary:
Resolves #75744
@rustbot label +needs-fcp +t-libs-api -t-libs
Aside, in case it keeps someone else from going down the same dead end: I looked at the
{break,continue}_value
methods and tried to make themconst
as part of this, but that's disallowed because of not havingconst Drop
, so put it back to not even unstably-const.