Create Atomic<T> type alias
#130543
Open
Create Atomic<T> type alias
#130543
+340
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
rustbot
added
O-hermit
7 tasks
This comment was marked as outdated.
This comment was marked as outdated.
CAD97
force-pushed
the
generic-atomic
branch
from
bacfd33
to
cc104b1
Compare
CAD97
commented
Sep 19, 2024
| macro impl_atomic_primitive( | ||
| $Atom:ident $(<$T:ident>)? ($Primitive:ty), | ||
| size($size:literal), | ||
| align($align:literal) $(,)? |
There was a problem hiding this comment.
FYI the align is given to impl_atomic_primitive! because while it isn't actually used in this form, it's needed for the form where Atomic<T> is the struct definition. So it'll make the next diff a little cleaner (and here is kinda just residual from paring this back to just do an alias initially).
|
Alright that's the merge conflicts fixed. If I end up needing to continue playing catch-up on some of the touched files, I'll probably just drop files' touch-up to use |
This comment has been minimized.
This comment has been minimized.
Noratrieb
approved these changes
Sep 19, 2024
|
r=me after fixing the import issues |
CAD97
force-pushed
the
generic-atomic
branch
from
cc104b1
to
67a79e8
Compare
in core/alloc/std only for now, and ignoring test files
CAD97
force-pushed
the
generic-atomic
branch
from
67a79e8
to
fbf092e
Compare
|
Also found a similar conflict with the windows futex impl plumbing via local check, so that's also resolved by the amend (hopefully; my local checkout suddenly is complaining about duplicate rmeta for crate IIRC I don't have perms to do this but might as well try: @bors r=Noratrieb rollup=iffy |
|
@CAD97: 🔑 Insufficient privileges: Not in reviewers |
|
@CAD97: 🔑 Insufficient privileges: not in try users |
|
@bors r=Noratrieb rollup=iffy |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 19, 2024
Create `Atomic<T>` type alias and use it in core/alloc/std where possible, ignoring test files for now. This is step one, creating the alias from `Atomic<T>` to `AtomicT`. The next step of flipping this and aliasing `AtomicT` to `Atomic<T>` will have a bigger impact, since `AtomicT` imports can be dropped once `Atomic::new` is a usable name. First commit is the true change. Second commit is mostly mechanical replacement of `AtomicT` type names with `Atomic<T>`. See [how this was done for `NonZero`](rust-lang#120257) for the rough blueprint I'm following. - ACP: rust-lang/libs-team#443 (comment) - Tracking issue: rust-lang#130539
12 tasks
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
whups |
bors
added
S-waiting-on-author
|
I
so it might take me a while to diagnose and fix whatever's going on. I did say rollup was iffy 😅 |
|
@CAD97 I usually give PRs a shot in a rollup even if they're iffy if they haven't ever been tried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use it in core/alloc/std where possible, ignoring test files for now.
This is step one, creating the alias from
Atomic<T>toAtomicT. The next step of flipping this and aliasingAtomicTtoAtomic<T>will have a bigger impact, sinceAtomicTimports can be dropped onceAtomic::newis a usable name.First commit is the true change. Second commit is mostly mechanical replacement of
AtomicTtype names withAtomic<T>.See how this was done for
NonZerofor the rough blueprint I'm following.Atomic<T>libs-team#443 (comment)Atomic#130539