Don't enable libcpp for llvm by default. #14506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To work with the snapshot builders this needs to be implicitly enabled for at least clang. Does the LLVM configure fail if the compiler being used is gcc? |
|
@alexcrichton I've changed it to just apply for clang. |
bors
added a commit
that referenced
this pull request
May 29, 2014
This used to be clang only but accidentally became the default for everyone.
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Jun 3, 2014
… in order to get rust-lang/rust#14506. Without this, Rust’s configure fails when g++ is used to build LLVM.
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Jun 4, 2014
… in order to get rust-lang/rust#14506. Without this, Rust’s configure fails when g++ is used to build LLVM.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…ykril fix: unify types in `infer_expr_coerce_never()` Fixes rust-lang#14506 rust-lang#14506 turned out to be a regression in type inference. `infer_expr_coerce_never()` added in rust-lang#14251 allows never-to-any coercion but should also perform ordinary type unification in other cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be clang only but accidentally became the default for everyone.