Always insert methods into the search index, even if we're currently in a private module #16767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a private module. Previously, this caused methods of re-exported types to not be inserted into the search index. This fix may introduce some false positives, but in my testing they appear as orphaned methods and end up not being inserted into the final search index at a later stage. Fixes issue rust-lang#11943
|
@SiegeLord could you add a test for this, perhaps just by grepping the index file? |
|
Rustdoc testing seems like a big project in itself (#13444)... let me glance at how tests are done these days, but I imagine it'll take me awhile to do this. |
|
I usually just throw a quick script in run-make. On Tue, Aug 26, 2014 at 5:37 PM, SiegeLord notifications@github.com wrote:
|
|
Ok, added a simple test. |
|
(Cycling to hopefully unstick bors.) |
bors
added a commit
that referenced
this pull request
Aug 29, 2014
Previously, this caused methods of re-exported types to not be inserted into the search index. This fix may introduce some false positives, but in my testing they appear as orphaned methods and end up not being inserted into the final search index at a later stage. Fixes issue #11943
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
…=Veykril internal: Expose snippet capability to diagnostic quickfixes Fixes rust-lang#16767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this caused methods of re-exported types to not be inserted into
the search index. This fix may introduce some false positives, but in my
testing they appear as orphaned methods and end up not being inserted into the
final search index at a later stage.
Fixes issue #11943