Prohibit type parameter shadowing with a clunky hammer. #20728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
huonw
force-pushed
the
type-param-shadowing
branch
from
213fc2f
to
bb5a114
Compare
This is a [breaking-change].
Change
impl<T> Foo<T> {
fn bar<T>(...
to (for example)
impl<T> Foo<T> {
fn bar<U>(...
Per RFC 459.
Closes rust-lang#19390.
huonw
force-pushed
the
type-param-shadowing
branch
from
bb5a114
to
92cd8ea
Compare
|
This looks like it should fix #20702 as well? |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 8, 2015
Conflicts: src/librustc_typeck/check/wf.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.