-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r+] Add rules for negative implementations #20972
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
683d20c
Record negative trait_impls separatedly
flaper87 199e0cd
Add test for missing default impl
flaper87 e644ca0
push_impls_of_trait is not needed, use map
flaper87 39fe05f
Negative impls are considered safe
flaper87 5aab863
Don't assemble bound impls if candidate's ambiguous
flaper87 9eec782
Check for negative impls for `Send` and `Sync`
flaper87 388e30f
Remove NoSend/NoSync
flaper87 bb04121
Don't use NoSend/NoSync in liballoc
flaper87 c6ab9a6
Don't use NoSend/NoSync in libstd
flaper87 9d42581
add a run-pass test that used to fail
flaper87 094397a
Fix coherence for negative implementations
flaper87 921ba5a
Don't use NoSend/NoSync in tests
flaper87 038aa0e
Allow negative impls just for Send and Sync
flaper87 aa642b3
addressed comments
flaper87 59775bb
fix latest changes fallout
flaper87 2adc8b5
populate impls *before* clonning the impls vec
flaper87 7cd762a
Docs fallout
flaper87 cb85223
fix pretty test fallout
flaper87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this redundant with raw pointers no longer being Send?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's redundant unless, for some reason,
NonZero
ends up implementingSend
. It doesn't now and I don't think it will so we could probably remove it. Although, the extra negative impl is harmless.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good practice though to be explicit; it serves as documentation. It'd be good to add some comments to the impls though saying why
Rc
is not sendable/sync. something likeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative, if we had such a thing, would be the equivalent of compile-fail unit tests though.