Deprecate in-tree rand, std::rand and #[derive(Rand)].
#21892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -24,6 +24,9 @@ pub fn expand_deriving_rand<F>(cx: &mut ExtCtxt, | |||
| push: F) where | |||
| F: FnOnce(P<Item>), | |||
| { | |||
| cx.span_warn(span, | |||
| "`derive(Rand)` is deprecated in favour of `derive_rand` on crates.io"); | |||
There was a problem hiding this comment.
Has this crate not been pushed to rust-lang/rand just yet? I see it on crates.io but not in git
There was a problem hiding this comment.
(I'm wondering if rand_macros may be a better name...)
There was a problem hiding this comment.
Hm yeah, I might go with rand_macros instead, but it's not super critical.
bors
added a commit
that referenced
this pull request
Feb 3, 2015
Use [`rand`](https://crates.io/crates/rand) and [`derive_rand`](https://crates.io/crates/derive_rand) from crates.io. [breaking-change]
|
💔 Test failed - auto-win-64-nopt-t |
|
@bors: retry |
Use the crates.io crate `rand` (version 0.1 should be a drop in replacement for `std::rand`) and `rand_macros` (`#[derive_Rand]` should be a drop-in replacement). [breaking-change]
|
@bors r=alexcrichton df1a |
bors
added a commit
that referenced
this pull request
Feb 4, 2015
Use [`rand`](https://crates.io/crates/rand) and [`derive_rand`](https://crates.io/crates/derive_rand) from crates.io. [breaking-change]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
randandderive_randfrom crates.io.[breaking-change]
As described in the RFC: rust-lang/rfcs#722 (comment)