Replace usage of slice::from_raw_buf with slice::from_raw_parts #21926
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Thanks @mzabaluev! This looks great to me, I agree it's best to hold off on r? @aturon as well, I'm happy with the naming of |
|
Looks good to me too, thanks! @bors: r+ 1bf653b |
|
⌛ Testing commit 1bf653b with merge 50612c6... |
|
💔 Test failed - auto-mac-32-opt |
New functions, slice::from_raw_parts and slice::from_raw_parts_mut, are added to implement the lifetime convention as agreed in RFC PR rust-lang#556. The functions slice::from_raw_buf and slice::from_raw_mut_buf are left deprecated for the time being.
mzabaluev
force-pushed
the
raw-lifetime
branch
from
1bf653b
to
fb6b970
Compare
|
Rebased: one more use of |
|
⌛ Testing commit fb6b970 with merge 68e7ae8... |
|
💔 Test failed - auto-win-64-nopt-t |
|
@bors: retry |
|
⌛ Testing commit fb6b970 with merge db851fd... |
New functions, `slice::from_raw_parts` and `slice::from_raw_parts_mut`, are added to implement the lifetime convention as agreed in rust-lang/rfcs#556. The functions `slice::from_raw_buf` and `slice::from_raw_mut_buf` are left deprecated for the time being. Holding back on changing the signature of `std::ffi::c_str_to_bytes` as consensus in rust-lang/rfcs#592 is building to replace it with a composition of other functions. Contribution to rust-lang#21923.
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
New functions, `slice::from_raw_parts` and `slice::from_raw_parts_mut`, are added to implement the lifetime convention as agreed in rust-lang/rfcs#556. The functions `slice::from_raw_buf` and `slice::from_raw_mut_buf` are left deprecated for the time being. Holding back on changing the signature of `std::ffi::c_str_to_bytes` as consensus in rust-lang/rfcs#592 is building to replace it with a composition of other functions. Contribution to #21923.
New functions,
slice::from_raw_partsandslice::from_raw_parts_mut,are added to implement the lifetime convention as agreed in rust-lang/rfcs#556.
The functions
slice::from_raw_bufandslice::from_raw_mut_bufareleft deprecated for the time being.
Holding back on changing the signature of
std::ffi::c_str_to_bytesas consensus in rust-lang/rfcs#592 is building to replace it with a composition of other functions.Contribution to #21923.