Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overloaded augmented assignments (a += b) #23171

Closed
wants to merge 1 commit into from
Closed

Overloaded augmented assignments (a += b) #23171

wants to merge 1 commit into from

Conversation

japaric
Copy link
Member

@japaric japaric commented Mar 8, 2015

Implements overload-able augmented/compound assignments, like a += b via the AddAssign trait, as specified in RFC 953

r? @nikomatsakis

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@japaric japaric mentioned this pull request Mar 8, 2015
Merged
@japaric
Copy link
Member Author

japaric commented Mar 8, 2015

RFC at rust-lang/rfcs#953

This was referenced Mar 8, 2015
Closed
Closed
@japaric
Copy link
Member Author

japaric commented Mar 11, 2015

(If anyone is looking, I've added the op_assign feature gate)

@bors
Copy link
Contributor

bors commented Mar 28, 2015

☔ The latest upstream changes (presumably #23796) made this pull request unmergeable. Please resolve the merge conflicts.

@japaric japaric mentioned this pull request May 16, 2015
Closed
@bors
Copy link
Contributor

bors commented May 24, 2015

☔ The latest upstream changes (presumably #25609) made this pull request unmergeable. Please resolve the merge conflicts.

@japaric japaric force-pushed the op-assign branch 2 times, most recently from eabc21c to 46c7202 Compare June 15, 2015 22:45
@bors
Copy link
Contributor

bors commented Jun 19, 2015

☔ The latest upstream changes (presumably #26351) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jun 27, 2015

☔ The latest upstream changes (presumably #26575) made this pull request unmergeable. Please resolve the merge conflicts.

@Gankra
Copy link
Contributor

Gankra commented Jul 27, 2015

@japaric I'm gonna go ahead and close this PR since it doesn't look like this is going to get through the RFC process anytime soon.

Your contributions, as always, are greatly appreciated!

@Gankra Gankra closed this Jul 27, 2015
@nikomatsakis nikomatsakis mentioned this pull request Sep 4, 2015
Closed
@japaric japaric changed the title [RFC] Overloaded assignment operations a += b Overloaded augmented assignments (a += b) Sep 11, 2015
@japaric
Copy link
Member Author

japaric commented Sep 11, 2015

Rebased, documented the traits and updated the description of E0368.

r? @nikomatsakis

@Gankra
Copy link
Contributor

Gankra commented Sep 11, 2015

@japaric github seems to refuse to reopen this, might need a new PR?

@japaric
Copy link
Member Author

japaric commented Sep 11, 2015

@gankro just sent #28345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@japaric @rust-highfive @bors @Gankra @brson