Fix some pub use privacy errors and a bit of resolve refactoring #23400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Make all tests public so we can call them from outside | ||
| // the module (note that the tests are re-exported and must | ||
| // be made public themselves to avoid privacy errors). | ||
| let mut result = (*i).clone(); |
There was a problem hiding this comment.
You're never supposed to clone AST nodes if you own them (can we make specific impls of Clone warn/error?), here's what you can do instead:
i.map(|mut i| { i.vis = ast::Public; i })
|
r=me with nits fixed - are there really no issues closed by this? |
|
#23266 is closed by this (see the comment on the second commit) |
|
@bors: r=eddyb |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb