Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use discriminant_value intrinsic for derive(PartialOrd) #24270

Merged
merged 10 commits into from
Apr 11, 2015
Merged

Use discriminant_value intrinsic for derive(PartialOrd) #24270

merged 10 commits into from
Apr 11, 2015

Commits on Apr 10, 2015

  1. Implement discriminant_value intrinsic 

    Implements an intrinsic for extracting the value of the discriminant
enum variant values. For non-enum types, this returns zero, otherwise it
returns the value we use for discriminant comparisons. This means that
enum types that do not have a discriminant will also work in this
arrangement.

This is (at least part of) the work on Issue rust-lang#24263
    @Aatch @pnkfelix
    Aatch authored and pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    41dd355 View commit details
    Browse the repository at this point in the history

  2. Add test for discriminant_value results

    @Aatch @pnkfelix
    Aatch authored and pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    800c5f8 View commit details
    Browse the repository at this point in the history

  3. Rebase discriminant_value test. Add case for a specialized repr.

    @pnkfelix
    pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    ea27391 View commit details
    Browse the repository at this point in the history

  4. Change derive expansions to use discriminant_value intrinsic. 

    Fix rust-lang#15523.
    @pnkfelix
    pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    6118795 View commit details
    Browse the repository at this point in the history

  5. Test case for new derive(PartialOrd) expansion.

    @pnkfelix
    pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    c44d40e View commit details
    Browse the repository at this point in the history

  6. Re-add a fixme after some investigation into what's going on.

    @pnkfelix
    pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    afb7acf View commit details
    Browse the repository at this point in the history

  7. Incorporate repr-attr into deriving(PartialOrd) to avoid truncation e… 

    …rrors.

remove out of date fixme.
    @pnkfelix
    pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    781fc90 View commit details
    Browse the repository at this point in the history

  8. Test case for 64-bit corner cases where truncation occurred before pr… 

    …ior commit.
    @pnkfelix
    pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    47016f9 View commit details
    Browse the repository at this point in the history

  9. fix some comments.

    @pnkfelix
    pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    847a897 View commit details
    Browse the repository at this point in the history

  10. Remove pretty-expanded from 2 tests; deriving(Ord) uses unstable intr… 

    …insic.
    @pnkfelix
    pnkfelix committed Apr 10, 2015
    Configuration menu
    Copy the full SHA
    05aaad1 View commit details
    Browse the repository at this point in the history