Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change a few error messages to give code suggestions #24683

Merged
merged 1 commit into from
Apr 23, 2015

Commits on Apr 21, 2015

  1. Change a few error messages to give code suggestions

    PR rust-lang#24242 added the ability to the compiler to directly give suggestions about
    how to modify code to fix an error. The new errors look like this:
    
        foobar.rs:5:12: 5:25 error: expected a path on the left-hand side of `+`,
                                    not `&'static Copy` [E0178]
        foobar.rs:5     let x: &'static Copy + 'static;
                               ^~~~~~~~~~~~~
        foobar.rs:5:12: 5:35 help: try adding parentheses (per RFC 438):
        foobar.rs:      let x: &'static (Copy + 'static);
    
        foobar.rs:2:13: 2:23 error: cast to unsized type: `&_` as `core::marker::Copy`
        foobar.rs:2     let x = &1 as Copy;
                                ^~~~~~~~~~
        foobar.rs:2:19: 2:23 help: try casting to a reference instead:
        foobar.rs:      let x = &1 as &Copy;
    
        foobar.rs:7:24: 7:25 error: expected expression, found `;`
        foobar.rs:7     let x = box (1 + 1);
                                           ^
        foobar.rs:7:13: 7:16 help: try using `box()` instead:
        foobar.rs:      let x = box() (1 + 1);
    
    This also modifies compiletest to give the ability to directly test suggestions
    given by error messages.
    ftxqxd committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    7d2231a View commit details
    Browse the repository at this point in the history