Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desugaring-based box placement-in (take-4 branch) #26180

Closed
wants to merge 36 commits into from
Closed

desugaring-based box placement-in (take-4 branch) #26180

wants to merge 36 commits into from

Commits on Jul 16, 2015

  1. Added Box<_> type annotations where necessary for overloaded-box.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    6a82cca View commit details
    Browse the repository at this point in the history

  2. prototype Placer protocol for unstable overloaded-box and placement-in.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    1d86250 View commit details
    Browse the repository at this point in the history

  3. Add feature-gates for desugaring-based box and placement-in. 

    update test/compile-fail/feature-gate-box-expr.rs to reflect new feature gates.

Part of what lands with Issue 22181.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    f773341 View commit details
    Browse the repository at this point in the history

  4. Accommodate error message explosion from box-desugaring in some tests. 

    See discussion on Issue 22231.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    ca73eb8 View commit details
    Browse the repository at this point in the history

  5. Update tests for desugaring box and placement-in. 

    Namely:

* Update run-pass/new-box-syntax
* Fix doc-embedded test for `alloc::boxed` to reflect new syntax.
* Fix test/debuginfo/box.rs to reflect new syntax.

Part of what lands with Issue 22181.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    a7ef6f4 View commit details
    Browse the repository at this point in the history

  6. Issue 22450: Address desugaring-box problems in [pretty] run-pass tes… 

    …t suite.

Precursor for overloaded-`box` and placement-`in`; see Issue 22181.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    a807ef4 View commit details
    Browse the repository at this point in the history

  7. Workaround issue 22462 by moving static value into its own module. 

    Precursor for overloaded-`box` and placement-`in`; see Issue 22181.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    fa0ec8c View commit details
    Browse the repository at this point in the history

  8. update alloc::boxed post rebase.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    6988850 View commit details
    Browse the repository at this point in the history

  9. update liballoc/lib.rs post rebase.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    3ec60e8 View commit details
    Browse the repository at this point in the history

  10. Hack for "unsafety hygiene" -- push_unsafe! and pop_unsafe! track… 

    … depth.

This is a total hack; it not only needs a feature-gate, but probably
should be feature-gated forever (if possible).

ignore-pretty in test/run-pass/pushpop-unsafe-okay.rs
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    6243ce3 View commit details
    Browse the repository at this point in the history

  11. Change signature for move_val_init intrinsic to take *mut T for `… 

    …dest`.

rebase update to typeck/check/mod.rs
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    0530a53 View commit details
    Browse the repository at this point in the history

  12. Avoid feature-warnings on stage0.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    c364f04 View commit details
    Browse the repository at this point in the history

  13. Revise placement-in expansion to use push/pop_unsafe and `move_val_… 

    …init`.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    70343c8 View commit details
    Browse the repository at this point in the history

  14. call push_compiler_expansion during the box and placement-in ex… 

    …pansions.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    69056cb View commit details
    Browse the repository at this point in the history

  15. turn on use of sugaring based box EXPR in parser.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    3ab0ebe View commit details
    Browse the repository at this point in the history

  16. Instrument rustc::middle::stability::maybe_do_stability_checking 

    in effort to understand treatment of `allow_internal_unstable`.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    bfe8884 View commit details
    Browse the repository at this point in the history

  17. Add Box::new in spots where new box protocol needs help with infere… 

    …nce.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    74676b2 View commit details
    Browse the repository at this point in the history

  18. Allow unstable code to be injected by box and placement-in expans… 

    …ions.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    a8ef3c4 View commit details
    Browse the repository at this point in the history

  19. librustc: Replace box with Box::new to assist inference for box p… 

    …rotocol.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    5d805b0 View commit details
    Browse the repository at this point in the history

  20. librustc_driver: Replace box with Box::new to assist inference fo… 

    …r box protocol.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    4d1635d View commit details
    Browse the repository at this point in the history

  21. librustc_lint: Replace box with Box::new to assist inference for … 

    …box protocol.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    7d77257 View commit details
    Browse the repository at this point in the history

  22. librustc_trans: Replace box with Box::new to assist inference for… 

    … box protocol.

Actually for some reason I opted for type-annotations for most of
this.  (And that's really what I should have been striving for in the
other commits, but its just easier to write `Box::new` most of the
time.)
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    0ec5b63 View commit details
    Browse the repository at this point in the history

  23. librustc_llvm: Replace box with Box::new to assist inference for … 

    …box protocol.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    52229f7 View commit details
    Browse the repository at this point in the history

  24. librustdoc: Replace box with Box::new to assist inference for box… 

    … protocol.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    91cf845 View commit details
    Browse the repository at this point in the history

  25. switch to box expr form in liblog.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    19020ef View commit details
    Browse the repository at this point in the history

  26. Add Box<_> annotations to run-pass tests for box protocol.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    fa89d84 View commit details
    Browse the repository at this point in the history

  27. Switched to Box::new in run-fail test.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    62650f9 View commit details
    Browse the repository at this point in the history

  28. Accommodate box protocol in compile-fail tests.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    474c00c View commit details
    Browse the repository at this point in the history

  29. add some (potentially unnecessary) #[inline] annotations in alloc::… 

    …boxed`.
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    30db8cb View commit details
    Browse the repository at this point in the history

  30. accommodate box protocol in run-pass-valgrind.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    36ebfeb View commit details
    Browse the repository at this point in the history

  31. Remove dependences on box-protocol from run-pass-fulldeps.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    6caa526 View commit details
    Browse the repository at this point in the history

  32. Fix box-protocol for run-make tests.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    4d80e03 View commit details
    Browse the repository at this point in the history

  33. Placate tidy, mostly in test suite code.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    1b8813d View commit details
    Browse the repository at this point in the history

  34. Placate box protocol by switching to Box::new in various test code.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    ef6d5e3 View commit details
    Browse the repository at this point in the history

  35. Revise lang_item demo to something unrelated to Box impl 

    Precursor for landing overloaded-box, since that will decouple the box
syntax from the exchange heap (and should eliminate the use of the
`malloc` and `free` lang items).

(This is a simplified approach to PR rust-lang#22499; note that I have once
again changes which lang item to use for the illustration.)
    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    afd9b94 View commit details
    Browse the repository at this point in the history

  36. revert back to the old syntax while landing the protocol alone.

    @pnkfelix
    pnkfelix committed Jul 16, 2015
    Configuration menu
    Copy the full SHA
    a61490c View commit details
    Browse the repository at this point in the history