Prepare for stabilizing libcore #27871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the modules in the standard library were just straight reexports of those in libcore, so remove all the "macro modules" from the standard library and just reexport what's in core directly.
This mirrors the same hierarchy in the standard library.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @aturon |
alexcrichton
force-pushed
the
stabilize-libcore
branch
from
63eb461
to
a19fa1f
Compare
| @@ -8,6 +8,10 @@ | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
|
|
|||
| // this is in principle private which is only made public for testing. do not | |||
| // expose us in the documentation as a result | |||
| #![doc(hidden)] | |||
There was a problem hiding this comment.
What's the point of this? Nobody is ever going to generate docs for libcoretest.
There was a problem hiding this comment.
Oh oops I thought this was libcore, looks like this already exists in libcore!
This commit stabilizes the prelude::v1 module of libcore after verifying that it's a subset of the prelude of the standard library with the addition of a few extension traits.
Stop using stability to hide the implementation details of ParseFloatError and
instead move the error type into the `dec2flt` module. Also move the
implementation blocks of `FromStr for f{32,64}` into `dec2flt` directly.
alexcrichton
force-pushed
the
stabilize-libcore
branch
from
a19fa1f
to
a2b932c
Compare
|
@bors: r+ |
|
📌 Commit a2b932c has been approved by |
bors
added a commit
that referenced
this pull request
Aug 22, 2015
These commits move libcore into a state so that it's ready for stabilization, performing some minor cleanup: * The primitive modules for integers in the standard library were all removed from the source tree as they were just straight reexports of the libcore variants. * The `core::atomic` module now lives in `core::sync::atomic`. The `core::sync` module is otherwise empty, but ripe for expansion! * The `core::prelude::v1` module was stabilized after auditing that it is a subset of the standard library's prelude plus some primitive extension traits (char, str, and slice) * Some unstable-hacks for float parsing errors were shifted around to not use the same unstable hacks (e.g. the `flt2dec` module is now used for "privacy"). After this commit, the remaining large unstable functionality specific to libcore is: * `raw`, `intrinsics`, `nonzero`, `array`, `panicking`, `simd` -- these modules are all unstable or not reexported in the standard library, so they're just remaining in the same status quo as before * `num::Float` - this extension trait for floats needs to be audited for functionality (much of that is happening in #27823) and may also want to be renamed to `FloatExt` or `F32Ext`/`F64Ext`. * Should the extension traits for primitives be stabilized in libcore? I believe other unstable pieces are not isolated to just libcore but also affect the standard library. cc #27701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits move libcore into a state so that it's ready for stabilization, performing some minor cleanup:
core::atomicmodule now lives incore::sync::atomic. Thecore::syncmodule is otherwise empty, but ripe for expansion!core::prelude::v1module was stabilized after auditing that it is a subset of the standard library's prelude plus some primitive extension traits (char, str, and slice)flt2decmodule is now used for "privacy").After this commit, the remaining large unstable functionality specific to libcore is:
raw,intrinsics,nonzero,array,panicking,simd-- these modules are all unstable or not reexported in the standard library, so they're just remaining in the same status quo as beforenum::Float- this extension trait for floats needs to be audited for functionality (much of that is happening in Remove dependencies on libm functions from libcore. #27823) and may also want to be renamed toFloatExtorF32Ext/F64Ext.I believe other unstable pieces are not isolated to just libcore but also affect the standard library.
cc #27701