Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to reflect #28260 and a workaround #29229

Merged
merged 2 commits into from
Oct 25, 2015

Conversation

SingingTree
Copy link
Contributor

This PR adds a note to the end of the Windows build instructions to reflect the issues detailed in #28260, as well as a work around using older versions of gcc. I've avoided going into detail as I did not wish to bloat the README, and so that the changes are easy to yank once the issue is resolved.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Could you link to the relevant issue from here as well? That way once it's closed this'll be at least a "little updated"!

@SingingTree
Copy link
Contributor Author

Sure thing. To clarify: link to #28260 in the README?

@alexcrichton
Copy link
Member

Yeah just a mention that there's a tracking issue for this weird behavior

@SingingTree
Copy link
Contributor Author

Sorted.

@alexcrichton
Copy link
Member

@bors: r+ a17d77b

bors added a commit that referenced this pull request Oct 24, 2015
…chton

This PR adds a note to the end of the Windows build instructions to reflect the issues detailed in #28260, as well as a work around using older versions of gcc. I've avoided going into detail as I did not wish to bloat the README, and so that the changes are easy to yank once the issue is resolved.
@bors
Copy link
Contributor

bors commented Oct 24, 2015

⌛ Testing commit a17d77b with merge 0be1bcd...

@bors bors merged commit a17d77b into rust-lang:master Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants