Rollup of 8 pull requests #29607
Closed
Rollup of 8 pull requests #29607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Nov 5, 2015
steveklabnik
commented
- Successful merges: 1.4 release notes #29416, Closes #24954 #29537, Mention what iterator terminators do with an empty iterator #29539, Fix #29542 #29567, Add note about HashMap::capacity's bounds #29568, Mention multiple impl blocks in TRPL #29571, Mention [T]::sort is stable in docs #29579, docs for Reflect: blank line after first sentence #29593
- Failed merges:
Reword "Writing the logic" paragraph to prevent `unwrap` being confused for a macro.
Rustdoc takes the first paragraph as a summary, so having a huge paragraph that ends with introducing an example looked somewhat wrong on the module page.
[Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md) More highlights would be good. I intend to go through and hyperlink all the APIs still.
Reword "Writing the logic" paragraph to prevent `unwrap` being confused for a macro (and other small changes to improve the flow of the paragraph). cc @steveklabnik
…veklabnik Rustdoc takes the first paragraph as a summary, so having a huge paragraph that ends with introducing an example looked somewhat wrong on the module page.
|
@bors: r+ p=1 |
|
📌 Commit 269e587 has been approved by |
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 269e587 with merge b39641b... |
|
💔 Test failed - auto-mac-64-nopt-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.