Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify some code #30934

Merged
merged 1 commit into from
Jan 16, 2016
Merged

simplify some code #30934

merged 1 commit into from
Jan 16, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 15, 2016

the None and the DefVariant paths were unused anyway.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 7476ae3e4b1eebbfb92f91b664a28d103835141e

@bors
Copy link
Contributor

bors commented Jan 15, 2016

☔ The latest upstream changes (presumably #30446) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 16, 2016

rebased. the conflict was in the deleted part

@nagisa
Copy link
Member

nagisa commented Jan 16, 2016

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jan 16, 2016

📌 Commit 1aacd9d has been approved by alexcrichton

bors added a commit that referenced this pull request Jan 16, 2016
the `None` and the `DefVariant` paths were unused anyway.
@bors
Copy link
Contributor

bors commented Jan 16, 2016

⌛ Testing commit 1aacd9d with merge 05aeeb3...

@bors bors merged commit 1aacd9d into rust-lang:master Jan 16, 2016
@oli-obk oli-obk deleted the simplify_const_eval branch January 19, 2016 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants