Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crate_name in E0152 error display #31818

Merged
merged 2 commits into from
Feb 25, 2016
Merged

Add crate_name in E0152 error display #31818

merged 2 commits into from
Feb 25, 2016

Conversation

GuillaumeGomez
Copy link
Member

Fixes #31788

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member Author

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned nikomatsakis Feb 22, 2016
@brson
Copy link
Contributor

brson commented Feb 25, 2016

@bors r+

While an improvement, this won't solve the issue linked in the op where there were two crates named libcore.

@bors
Copy link
Contributor

bors commented Feb 25, 2016

📌 Commit dfe72fa has been approved by brson

@Manishearth Manishearth mentioned this pull request Feb 25, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 25, 2016
@Manishearth
Rollup merge of rust-lang#31818 - GuillaumeGomez:error_display, r=brson
7731cdc 
Fixes rust-lang#31788
bors added a commit that referenced this pull request Feb 25, 2016
@bors
Auto merge of #31882 - Manishearth:rollup, r=Manishearth
c9852e2 
- Successful merges: #31362, #31793, #31800, #31809, #31818, #31827, #31831, #31835, #31837, #31846
- Failed merges:
@bors bors merged commit dfe72fa into rust-lang:master Feb 25, 2016
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 29, 2016
Merged
bors added a commit that referenced this pull request Mar 8, 2016
@bors
Auto merge of #31957 - GuillaumeGomez:error_display, r=brson
81e0323 
Add error file for E0152

It completes #31818.

However it is not complete yet:
 * test will need to be updated
 * the file name displayed is a bit too unclear.

I'm not sure yet what's the "correct" file name to display. If anyone has an idea on this, it'd be very appreciated.

r? @brson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-highfive @brson @bors @nikomatsakis